mon: fix osd failure info in mon#6278
Merged
liewegas merged 2 commits intoceph:masterfrom Nov 25, 2015
Merged
Conversation
Member
There was a problem hiding this comment.
If I'm reading this correct it means a failure report cancellation should not be ignored, even if the osd is down. That makes sense, but can you break that into a separate commit please?
Member
|
The report cancellation part looks good to me too. Can you rebase on current master and break it into 2 patches please? Thanks! |
307d2e0 to
07f59f9
Compare
Contributor
Author
|
@liewegas , I fix the PR based on your comment. Thanks. |
07f59f9 to
86ab9a1
Compare
when the network adapter of node A run into error, osd in this node would tell mon other osd's heartbeat is timeout also. So when rebind fail after retry 3 times, the osd should cancel in-flight failure report send to mon before. Signed-off-by: Xinze Chi <xinze@xsky.com>
do not ignore a failure report cancellation form osd even if it is down. Signed-off-by: Xinze Chi <xinze@xsky.com>
86ab9a1 to
48a71a7
Compare
liewegas
added a commit
that referenced
this pull request
Nov 25, 2015
osd: cancel failure reports if we fail to rebind network Reviewed-by: Sage Weil <sage@redhat.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the network adapter of node A run into error, osd in this node
would tell mon other osd's heartbeat is timeout also. So when rebind
fail after retry 3 times, the osd should cancel in-flight failure report
send to mon before.
Signed-off-by: Xinze Chi xinze@xsky.com