Skip to content

cmake/modules/FindBoost.cmake: fix Boost_NO_WARN_NEW_VERSIONS#62580

Merged
adamemerson merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-findboost-warning
Apr 9, 2025
Merged

cmake/modules/FindBoost.cmake: fix Boost_NO_WARN_NEW_VERSIONS#62580
adamemerson merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-findboost-warning

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Mar 31, 2025

#61084 bumped up the version used to 1.87. The warning should be for 1.88, same as it was 1.86 when we used 1.85.

-- Performing Test HAS_NULLPTR_WARNING - Success
-- Checking for one of the modules 'libcares'
-- Found Boost: /opt/ceph/include (found suitable version "1.87.0", minimum required is "1.73.0")  
CMake Warning at cmake/modules/FindBoost.cmake:1413 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  cmake/modules/FindBoost.cmake:1538 (_Boost_COMPONENT_DEPENDENCIES)
  cmake/modules/FindBoost.cmake:2157 (_Boost_MISSING_DEPENDENCIES)
  src/CMakeLists.txt:403 (_find_package)
  src/seastar/cmake/SeastarDependencies.cmake:136 (find_package)
  src/seastar/CMakeLists.txt:395 (seastar_find_dependencies)

Fixes: https://tracker.ceph.com/issues/70725

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

ceph#61084 bumped up the version used to
1.87. The warning should be for 1.88, same as it was 1.86 when we used
1.85.

Fixes: https://tracker.ceph.com/issues/70725

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 3, 2025

jenkins test make check

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 3, 2025

jenkins test make check arm64

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 3, 2025

Merging based on make check

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 7, 2025

jenkins test make check

@adamemerson adamemerson merged commit 83e3eaf into ceph:main Apr 9, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants