Conversation
travisn
left a comment
There was a problem hiding this comment.
Just to confirm, Rook currently calls this command for mgr status, only for a return code to confirm that the mgr daemon is alive and responding.
ceph --admin-daemon /run/ceph/ceph-mgr.a.asok status
Looks like the new command will respond to this with an exit code 0, so the new command looks like it will work, thanks.
The Rook operator relies on a `status` (asok) command to the mgr to verify it is operational. However, this command was actually served by the CephFS `Client` library that the ceph-mgr daemon statically linked in and used for sending MDS commands. That statically linked client was removed via 048fc68 (case insensitive directory tree feature). So, add a legitimate ceph-mgr status command which simply outputs an empty dictionary and returns success (0). TBD on adding useful information. Fixes: 048fc68 Fixes: https://tracker.ceph.com/issues/70571 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
|
This PR is under test in https://tracker.ceph.com/issues/70638. |
|
jenkins test make check |
Fixes: https://tracker.ceph.com/issues/70571 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
* refs/pull/62465/head: qa: add test for `mgr status` command mgr: add status command
The failures are independent from this PR? |
yes, they already have appeared in earlier teuthology tests on |
| f->close_section(); | ||
| return 0; | ||
| } else { | ||
| return -ENOSYS; |
There was a problem hiding this comment.
Nit:
ENOSYS is for "function not supported". Does a command other than "status" qualify as a function? Why not a more general ENOTSUP?
There was a problem hiding this comment.
ENOSYS conventionally indicates that a requested method/function/syscall is not known to the kernel (or in this case, the ceph daemon). That would be appropriate in this context.
ENOTSUP is more for the case where the system understands the request but cannot implement it because of some contextual problem.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition