Skip to content

client: ll_walk will process absolute paths as relative#62406

Merged
batrick merged 2 commits intoceph:mainfrom
batrick:i70573
Mar 25, 2025
Merged

client: ll_walk will process absolute paths as relative#62406
batrick merged 2 commits intoceph:mainfrom
batrick:i70573

Conversation

@batrick
Copy link
Member

@batrick batrick commented Mar 20, 2025 •
edited
Loading

cc @anoopcs9

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

batrick and others added 2 commits March 19, 2025 21:33
@batrick
test/client: add ll_walk test with cwd and root path
0306789 
Fixes: https://tracker.ceph.com/issues/70573
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
client: process path without inode anchor
25eb99d 
ll_walk was wrongly coded to make the input file path relative to ino=0. That inode
does not exist and isn't considered the root inode.

Fixes: https://tracker.ceph.com/issues/70573
Fixes: e08210d
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick batrick requested a review from a team March 20, 2025 01:34
@anoopcs9
Copy link
Contributor

anoopcs9 commented Mar 20, 2025 •
edited
Loading

Purely from a reproducer perspective I can confirm that the changes are looking good.

ceph_chdir("/dir") => OK
ceph_getcwd() => /dir
ceph_ll_walk("/dir") => Success -- previously ENOENT

dparmar18
dparmar18 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dparmar18
Copy link
Contributor

dparmar18 commented Mar 21, 2025

Tested locally, works fine.

@batrick
Copy link
Member Author

batrick commented Mar 24, 2025

This PR is under test in https://tracker.ceph.com/issues/70638.

batrick added a commit to batrick/ceph that referenced this pull request Mar 25, 2025
@batrick
Merge PR ceph#62406 into wip-pdonnell-testing-20250324.181635-debug
7b39987 
* refs/pull/62406/head:
	client: process path without inode anchor
	test/client: add ll_walk test with cwd and root path
@batrick batrick merged commit 1f0900c into ceph:main Mar 25, 2025
12 checks passed
@batrick batrick deleted the i70573 branch March 25, 2025 16:12
This was referenced Mar 25, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees

No one assigned

Labels

bug-fix cephfs Ceph File System needs-qa wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@batrick @anoopcs9 @dparmar18