Skip to content

squid: cephfs,mon: don't disallow "mds/fs fail" when other MDS/FS has health warning#62052

Open
rishabh-d-dave wants to merge 9 commits intoceph:squidfrom
rishabh-d-dave:check-mds-id-squid
Open

squid: cephfs,mon: don't disallow "mds/fs fail" when other MDS/FS has health warning#62052
rishabh-d-dave wants to merge 9 commits intoceph:squidfrom
rishabh-d-dave:check-mds-id-squid

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Feb 28, 2025

Backport ticket: https://tracker.ceph.com/issues/70237
Backport ticket: https://tracker.ceph.com/issues/70235

Original PR: #61554

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rishabh-d-dave rishabh-d-dave requested a review from a team as a code owner February 28, 2025 12:05
@rishabh-d-dave rishabh-d-dave requested a review from a team February 28, 2025 12:05
@github-actions github-actions bot added this to the squid milestone Feb 28, 2025
@rishabh-d-dave rishabh-d-dave force-pushed the check-mds-id-squid branch 2 times, most recently from 6dce48a to c6ab226 Compare February 28, 2025 12:12
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@kotreshhr
Copy link
Contributor

@rishabh-d-dave please fix the merge conflict

@rishabh-d-dave
Copy link
Contributor Author

@rishabh-d-dave please fix the merge conflict

Done.

@rishabh-d-dave
Copy link
Contributor Author

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@kotreshhr
Copy link
Contributor

jenkins test make check

@joscollin
Copy link
Member

This PR is under test in https://tracker.ceph.com/issues/73331.

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@neesingh-rh
Copy link
Contributor

@rishabh-d-dave This backport PR needs rebase, can u pls?

@neesingh-rh
Copy link
Contributor

@rishabh-d-dave This backport PR needs rebase, can u pls?

request for rebase @rishabh-d-dave ?

Fixes: https://tracker.ceph.com/issues/69694
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 2217002)

Conflicts:
src/mon/MDSMonitor.h
- The region where the patch had to be applied was different in squid
  compared to main branch.
MDS_CACHE_OVERSIZE warning.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 5a7834b)
health warning.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 95a812a)

Conflicts:
qa/tasks/cephfs/test_admin.py
- File contents is somewhat different in squid vs main, leading to
  conflict.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 7f5553c)
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit cf68e49)
warnings.

Fixes: https://tracker.ceph.com/issues/69707
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0437952)

Conflicts:
src/mon/MDSMonitor.cc
- region where the patch was to be applied is different in squid
  compared to main

Conflicts:
src/mon/MDSMonitor.h
- The region where the patch has to be applied is different in Squid
  branch compared to the mainb branch.
tha generates MDS_CACHE_OVERSIZE warning.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit d53be13)
health warnings.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 59511e6)

Conflicts:
qa/tasks/cephfs/test_admin.py
-  the region where the patch has to be applied is different in squid
   compared to squid.
Use const qualifier since warnings vector won't be modified by the
helper methods and use also use a reference instead of a regular
variable.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 5ee8321)
@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

jenkins test windows

@neesingh-rh
Copy link
Contributor

jenkins retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants