cephfs,mon: don't disallow "mds/fs fail" when other MDS/FS has health warning#61554
Merged
rishabh-d-dave merged 9 commits intoceph:mainfrom Feb 28, 2025
Merged
cephfs,mon: don't disallow "mds/fs fail" when other MDS/FS has health warning#61554rishabh-d-dave merged 9 commits intoceph:mainfrom
rishabh-d-dave merged 9 commits intoceph:mainfrom
Conversation
Fixes: https://tracker.ceph.com/issues/69694 Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
commented
Jan 28, 2025
c13f7c3 to
c49dfcc
Compare
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
79bb9b6 to
dee898b
Compare
MDS_CACHE_OVERSIZE warning. Signed-off-by: Rishabh Dave <ridave@redhat.com>
health warning. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
warnings. Fixes: https://tracker.ceph.com/issues/69707 Signed-off-by: Rishabh Dave <ridave@redhat.com>
tha generates MDS_CACHE_OVERSIZE warning. Signed-off-by: Rishabh Dave <ridave@redhat.com>
health warnings. Signed-off-by: Rishabh Dave <ridave@redhat.com>
Use const qualifier since warnings vector won't be modified by the helper methods and use also use a reference instead of a regular variable. Signed-off-by: Rishabh Dave <ridave@redhat.com>
dee898b to
5ee8321
Compare
batrick
approved these changes
Feb 6, 2025
Contributor
Author
|
jenkins test api |
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/69873. |
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Feb 8, 2025
* refs/pull/61554/head: mon,cephfs: small improvement for health warning methods qa/cephfs: test that failing a FS is possible when other MDS/FS has... qa/cephfs: allow detecting MDS ID from FS object for method the.. mon,cephfs: don't disallow "fs fail" when other FS/MDS has health... cephfs,mon: rename variable to a better name mon,cephfs: fix indentation level for a code block qa/cephfs: test that a MDS can be failed when other FS/MDS has a... qa/cephfs: allow passing MDS ID to method that generate... mon,cephfs: check MDS ID before aborting "mds fail" command Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
rishabh-d-dave
commented
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/69694
Fixes: https://tracker.ceph.com/issues/69707
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e