squid: mgr/vol: print proper message when subvolume metadata filename is too long#62049
Open
rishabh-d-dave wants to merge 2 commits intoceph:squidfrom
Open
squid: mgr/vol: print proper message when subvolume metadata filename is too long#62049rishabh-d-dave wants to merge 2 commits intoceph:squidfrom
rishabh-d-dave wants to merge 2 commits intoceph:squidfrom
Conversation
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71055. |
Member
|
jenkins test docs |
1 similar comment
Contributor
Author
|
jenkins test docs |
long. When combination of subvolume group name and subvolume name is longer than 248 characters, it leads to a failure because the metadata file is a combination of both of these along with ":", "_" and ".meta". Currently, when this comibnation longer than 248 characters, a bunch stacktraces are printed along with multiple errors. This confuses the user as well as looks bad. Fixes: https://tracker.ceph.com/issues/69865 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 82fc1e7)
subvolume metadata file name length is too long. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 01f8f71)
6cd31d5 to
919d27e
Compare
Contributor
Author
|
jenkins test docs |
Contributor
Author
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/70230
backport of #61706
parent tracker: https://tracker.ceph.com/issues/69865
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh