mgr/vol: print proper message when subvolume metadata filename is too long#61706
Merged
rishabh-d-dave merged 2 commits intoceph:mainfrom Feb 28, 2025
Merged
Conversation
d59aaff to
83e716a
Compare
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/69873. |
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Feb 8, 2025
* refs/pull/61706/head: qa/cephfs: add tests for "fs subvolume create" command when... mgr/vol: print proper message when subvolume metadata filename is too...
vshankar
previously requested changes
Feb 24, 2025
long. When combination of subvolume group name and subvolume name is longer than 248 characters, it leads to a failure because the metadata file is a combination of both of these along with ":", "_" and ".meta". Currently, when this comibnation longer than 248 characters, a bunch stacktraces are printed along with multiple errors. This confuses the user as well as looks bad. Fixes: https://tracker.ceph.com/issues/69865 Signed-off-by: Rishabh Dave <ridave@redhat.com>
subvolume metadata file name length is too long. Signed-off-by: Rishabh Dave <ridave@redhat.com>
83e716a to
01f8f71
Compare
rishabh-d-dave
commented
Feb 28, 2025
Requested change was incorporated.
This was referenced Feb 28, 2025
vshankar
reviewed
Jun 5, 2025
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| FILE_NAME_MAX = 255 |
Contributor
There was a problem hiding this comment.
Sorry to comment on a merged PR, but this shoud be NAME_MAX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When combination of subvolume group name and subvolume name is longer
than 248 characters, it leads to a failure because the metadata file is
a combination of both of these along with ":", "_" and ".meta".
Currently, when this comibnation longer than 248 characters, a bunch
stacktraces are printed along with multiple errors. This confuses the
user as well as looks bad.
Fixes: https://tracker.ceph.com/issues/69865
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e