mds: add a proper check to evict clients with id 0 by neesingh-rh · Pull Request #61981 · ceph/ceph

neesingh-rh · 2025-02-24T15:16:57Z

Follow up of #49974

Fixes: https://tracker.ceph.com/issues/70198
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

src/mds/SessionMap.cc

vshankar · 2025-02-26T13:21:37Z

Follow up of #49974

Even if its a follow up, please create a tracker (for backport tracking) and link the followup comment in it.

neesingh-rh · 2025-02-27T10:36:07Z

Follow up of #49974

Even if its a follow up, please create a tracker (for backport tracking) and link the followup comment in it.

Created the tracker and have linked it to the PR

neesingh-rh · 2025-03-04T18:26:49Z

jenkins retest this please

batrick

[ RUN      ] MDSSessionFilter.ParseGood
Testing '[id=34]'
Testing '[auth_name=foxtrot]'
Testing '[state=reconnecting]'
Testing '[reconnecting=true]'
Testing '[client_metadata.root=/foo/bar]'
Testing '[]'
Testing '[id=123]'
Testing '[id=34,client_metadata.root=/foo/bar,auth_name=foxtrot,state=reconnecting,reconnecting=true]'
[       OK ] MDSSessionFilter.ParseGood (1 ms)
[ RUN      ] MDSSessionFilter.ParseBad
Testing '[rhubarb]'
Testing '[id=]'
unknown file: Failure
C++ exception with description "stoi" thrown in the test body.
[  FAILED  ] MDSSessionFilter.ParseBad (0 ms)

neesingh-rh · 2025-03-06T05:01:43Z

[ RUN      ] MDSSessionFilter.ParseGood
Testing '[id=34]'
Testing '[auth_name=foxtrot]'
Testing '[state=reconnecting]'
Testing '[reconnecting=true]'
Testing '[client_metadata.root=/foo/bar]'
Testing '[]'
Testing '[id=123]'
Testing '[id=34,client_metadata.root=/foo/bar,auth_name=foxtrot,state=reconnecting,reconnecting=true]'
[       OK ] MDSSessionFilter.ParseGood (1 ms)
[ RUN      ] MDSSessionFilter.ParseBad
Testing '[rhubarb]'
Testing '[id=]'
unknown file: Failure
C++ exception with description "stoi" thrown in the test body.
[  FAILED  ] MDSSessionFilter.ParseBad (0 ms)

All checks are green, PTAL

github-actions · 2025-05-17T14:01:37Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

neesingh-rh · 2025-05-29T11:17:47Z

@vshankar @rishabh-d-dave Can we add this in any of upcoming teuthology runs

rishabh-d-dave · 2025-06-13T10:53:00Z

This PR is under test in https://tracker.ceph.com/issues/71663.

rishabh-d-dave · 2025-06-16T18:27:30Z

This PR is under test in https://tracker.ceph.com/issues/71663.

A large number of jobs failed to an unrelated error, deferring QA run until it is fixed.

rishabh-d-dave · 2025-06-17T17:40:08Z

This PR is under test in https://tracker.ceph.com/issues/71703.

rishabh-d-dave

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250617173904

rishabh-d-dave · 2025-06-26T08:28:32Z

One of the CI job is stuck and there's no way to re-trigger until PR branch pushed with again or if we close and open the PR. Proceeding to do the latter.

neesingh-rh · 2025-06-26T12:53:28Z

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250617173904
One of the CI job is stuck and there's no way to re-trigger until PR branch pushed with again or if we close and open the PR. Proceeding to do the latter.

Waiting for CI to pass now.

@neesingh-rh One of the CI jobs is failing consistently, I think the PR branch needs to be rebased on more recent version of main.

Rebased!

neesingh-rh · 2025-07-23T09:17:56Z

jenkins retest this please

github-actions · 2025-09-21T10:01:50Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

github-actions · 2025-10-21T11:02:02Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

github-actions · 2025-12-28T10:02:01Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

github-actions · 2026-01-27T11:03:29Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

vshankar · 2026-03-04T13:54:08Z

This PR is under test in https://tracker.ceph.com/issues/75334.

* refs/pull/61981/head: Reviewed-by: Rishabh Dave <ridave@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

vshankar

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_--_2026#wip-vshankar-testing-20260304135307

vshankar · 2026-03-17T09:57:56Z

jenkins retest this please

vshankar · 2026-03-17T10:58:05Z

@neesingh-rh please mixup the failing jenkins test. This is ready to merge.

neesingh-rh · 2026-03-18T03:55:46Z

jenkins test docs

neesingh-rh · 2026-03-18T04:00:46Z

@neesingh-rh please mixup the failing jenkins test. This is ready to merge.

readthedocs check is failing, which seems unrelated to the change.

vshankar · 2026-03-18T08:52:19Z

@neesingh-rh - can you rebase and push please?

Fixes: https://tracker.ceph.com/issues/70198 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>

…consecutive zeroes Fixes: https://tracker.ceph.com/issues/70198 Signed-off-by: neeraj pratap singh <neerajpratapsingh@li-ff7f0d4c-3462-11b2-a85c-d4004c0fa1a0.ibm.com>

neesingh-rh · 2026-03-18T09:35:14Z

@neesingh-rh - can you rebase and push please?

Rebased

vshankar · 2026-03-20T04:34:52Z

jenkins retest this please

vshankar · 2026-03-20T07:14:14Z

jenkins test api

github-actions bot added the cephfs Ceph File System label Feb 24, 2025

neesingh-rh force-pushed the wip-fix-check-for-zero branch from fa1ca9e to 4d66ee4 Compare February 24, 2025 15:33

batrick requested changes Feb 24, 2025

View reviewed changes

src/mds/SessionMap.cc Outdated Show resolved Hide resolved

neesingh-rh force-pushed the wip-fix-check-for-zero branch 2 times, most recently from a81707c to 38edd19 Compare February 27, 2025 03:49

github-actions bot added the tests label Feb 27, 2025

neesingh-rh requested a review from batrick March 4, 2025 09:50

batrick approved these changes Mar 4, 2025

View reviewed changes

batrick requested changes Mar 5, 2025

View reviewed changes

neesingh-rh force-pushed the wip-fix-check-for-zero branch 2 times, most recently from 170255a to 4ffdc40 Compare March 5, 2025 19:02

neesingh-rh requested a review from batrick March 6, 2025 05:01

batrick approved these changes Mar 18, 2025

View reviewed changes

batrick added the needs-qa label Mar 18, 2025

github-actions bot added the stale label May 17, 2025

rishabh-d-dave added wip-rishabh-testing Rishabh's testing label and removed stale labels May 29, 2025

rishabh-d-dave removed the wip-rishabh-testing Rishabh's testing label label Jun 16, 2025

rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Jun 17, 2025

rishabh-d-dave approved these changes Jun 26, 2025

View reviewed changes

neesingh-rh force-pushed the wip-fix-check-for-zero branch from 4ffdc40 to 8710168 Compare June 26, 2025 12:53

github-actions bot added the stale label Sep 21, 2025

github-actions bot closed this Oct 21, 2025

neesingh-rh reopened this Oct 29, 2025

github-actions bot removed the stale label Oct 29, 2025

github-actions bot added the stale label Dec 28, 2025

github-actions bot closed this Jan 27, 2026

neesingh-rh reopened this Jan 28, 2026

github-actions bot removed the stale label Jan 28, 2026

vshankar added the wip-vshankar-testing label Mar 4, 2026

vshankar added a commit to vshankar/ceph that referenced this pull request Mar 16, 2026

Merge PR ceph#61981 into wip-vshankar-testing-20260313.134322

151bc0e

* refs/pull/61981/head: Reviewed-by: Rishabh Dave <ridave@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

vshankar approved these changes Mar 17, 2026

View reviewed changes

neeraj pratap singh added 2 commits March 18, 2026 15:04

mds: add a proper check to evict clients with id 0

84b0a0d

Fixes: https://tracker.ceph.com/issues/70198 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>

qa: test case for evicting clients with id having multiple number of …

3689aef

…consecutive zeroes Fixes: https://tracker.ceph.com/issues/70198 Signed-off-by: neeraj pratap singh <neerajpratapsingh@li-ff7f0d4c-3462-11b2-a85c-d4004c0fa1a0.ibm.com>

neesingh-rh force-pushed the wip-fix-check-for-zero branch from 8710168 to 3689aef Compare March 18, 2026 09:34

Conversation

neesingh-rh commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

vshankar commented Feb 26, 2025

Uh oh!

neesingh-rh commented Feb 27, 2025

Uh oh!

neesingh-rh commented Mar 4, 2025

Uh oh!

batrick left a comment

Choose a reason for hiding this comment

Uh oh!

neesingh-rh commented Mar 6, 2025

Uh oh!

github-actions bot commented May 17, 2025

Uh oh!

neesingh-rh commented May 29, 2025

Uh oh!

rishabh-d-dave commented Jun 13, 2025

Uh oh!

rishabh-d-dave commented Jun 16, 2025

Uh oh!

rishabh-d-dave commented Jun 17, 2025

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Jun 26, 2025

Uh oh!

neesingh-rh commented Jun 26, 2025

Uh oh!

neesingh-rh commented Jul 23, 2025

Uh oh!

github-actions bot commented Sep 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

github-actions bot commented Dec 28, 2025

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

vshankar commented Mar 4, 2026

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

vshankar commented Mar 17, 2026

Uh oh!

vshankar commented Mar 17, 2026

Uh oh!

neesingh-rh commented Mar 18, 2026

Uh oh!

neesingh-rh commented Mar 18, 2026

Uh oh!

vshankar commented Mar 18, 2026

Uh oh!

neesingh-rh commented Mar 18, 2026

Uh oh!

vshankar commented Mar 20, 2026

Uh oh!

vshankar commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

neesingh-rh commented Feb 24, 2025 •

edited

Loading