LogMonitor: set no_reply for forward MLog commands#61933
Merged
SrinivasaBharath merged 1 commit intoceph:mainfrom Mar 7, 2025
Merged
Conversation
On streach mod clusters we can see slow ops when removing and adding osds with --zap --force when osds connected to peon monitor and forwarding the MLog to leader. the no_reply is set only when we are connected to the leader, this fix will add also the other option - so no_reply set anyway. Fixes: https://tracker.ceph.com/issues/54489 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
rzarzynski
approved these changes
Feb 20, 2025
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
LGTM with just a nit on indentation.
| done: | ||
| mon.no_reply(op); | ||
| return true; | ||
| done: |
Contributor
There was a problem hiding this comment.
nit: let's keep the indentation as it was previously.
| return true; | ||
| done: | ||
| mon.no_reply(op); | ||
| return (!num_new); |
Contributor
There was a problem hiding this comment.
ACK, for the nothing new case (num_new == 0), the function returns true.
| goto done; | ||
| } | ||
|
|
||
| return false; |
Contributor
There was a problem hiding this comment.
(Just writing down my understanding)
For this case the preprocess_log() can be executed twice: once by a peon, once by leader. This is directed by the PaxosService:
// preprocess
if (preprocess_query(op))
return true; // easy!
// leader?
if (!mon.is_leader()) {
mon.forward_request_leader(op);
return true;
} Monitor::no_reply() doesn't do much on peons, but on leader it generates the MRoute which absence is the crux of the bug.
void Monitor::no_reply(MonOpRequestRef op)
{
MonSession *session = op->get_session();
Message *req = op->get_req();
if (session->proxy_con) {
dout(10) << "no_reply to " << req->get_source_inst()
<< " via " << session->proxy_con->get_peer_addr()
<< " for request " << *req << dendl;
session->proxy_con->send_message(new MRoute(session->proxy_tid, NULL));
op->mark_event("no_reply: send routed request");
} else {
dout(10) << "no_reply to " << req->get_source_inst()
<< " " << *req << dendl;
op->mark_event("no_reply");
}
} OK!
Contributor
|
RADOS Approved: https://tracker.ceph.com/issues/70274#note-5 |
Contributor
|
jenkins test api |
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Mar 10, 2025
…r-forward-msg-noreply LogMonitor: set no_reply for forward MLog commands
This was referenced Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On streach mod clusters we can see slow ops when
removing and adding osds with --zap --force when osds connected to peon monitor and forwarding the MLog to leader. the no_reply is set only when we are connected to the leader, this fix will add also the other option - so no_reply set anyway.
Fixes: https://tracker.ceph.com/issues/54489
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e