squid: qa: do read checks with non-empty file#61858
Merged
joscollin merged 1 commit intoceph:squidfrom Oct 16, 2025
Merged
Conversation
Linux will optimize out reads to a file known to be empty. Fixes: https://tracker.ceph.com/issues/53859 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit e3ed3b3)
Member
Author
|
jenkins test make check |
1 similar comment
Member
Author
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/71012. |
Member
|
This PR is under test in https://tracker.ceph.com/issues/73450. |
joscollin
approved these changes
Oct 16, 2025
Member
joscollin
left a comment
There was a problem hiding this comment.
All pool-perm tests passed here:
https://pulpito.ceph.com/jcollin-2025-10-10_05:57:09-fs:functional-wip-jcollin-testing-20251010.002614-squid-distro-default-smithi/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/69958
backport of #61675
parent tracker: https://tracker.ceph.com/issues/53859
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh