mgr/vol: add a helpful comment in async_job.py#61541
Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom Mar 1, 2025
Merged
mgr/vol: add a helpful comment in async_job.py#61541rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave merged 1 commit intoceph:mainfrom
Conversation
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
8f566ea to
cec9351
Compare
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test windows |
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/69873. |
rishabh-d-dave
added a commit
to rishabh-d-dave/ceph
that referenced
this pull request
Feb 8, 2025
* refs/pull/61541/head: mgr/vol: add a helpful comment in async_job.py
cec9351 to
75e5b92
Compare
Signed-off-by: Rishabh Dave <ridave@redhat.com>
75e5b92 to
0d930f2
Compare
Contributor
Author
|
An extra line (which was inconsequential since a variable was define by it but not used anywhere else) was added besides the comment. Removed it now. |
batrick
approved these changes
Feb 25, 2025
Contributor
Author
|
jenkins test make check arm64 |
2 similar comments
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
QA run was successful. https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-rishabh-testing-20250207204003-debug-4. Waiting for make check arm64 to pass before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e