Merged
Conversation
Contributor
Author
|
test is still failing after the fix. see: https://tracker.ceph.com/issues/69473#note-3 |
tchaikov
reviewed
Jan 16, 2025
since it is only a suggestion for debian. this is a regression from: ceph#60666 Fixes: https://tracker.ceph.com/issues/69473 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
5bc02cf to
e443d75
Compare
cbodley
approved these changes
Jan 16, 2025
Contributor
Author
|
ubuntu tests are also passing: https://pulpito.ceph.com/yuvalif-2025-01-16_16:49:48-rgw:lua-main-distro-default-smithi/ |
Member
|
I encountered this while delving into teuthology errors I encountered. Given the two approvals and that it passed QA I went ahead and merged it. No backports are listed and the PR that is linked and that introduced this regression had no backports either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since it is only a suggestion for debian.
this is a regression from: #60666
Fixes: https://tracker.ceph.com/issues/69473
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e