Conversation
One can attach lua scripts as sort of hooks to implement dynamic checks or transformations of RGW requests since Ceph Pacific. Thus, a lua library is now required for base support and optionally one can use the luarocks deployment and management system for Lua modules to use more advanced scripts/modules. With commit 46500ca ("rgw/test/lua: add lua integration tests suite") the dependency relations got cleaned up, as the respective entries were missing completely from debian/control. But that commit is pulling in much more than required due to adding the devel package `liblua5.3-dev` instead of the library-only `liblua5.3-0` one, and having `luarocks` as hard dependency compared to an optional Suggests. Fixing that avoids pulling in a whole build/compiler/autotools/... stack with 65 new packages just when one wants to use librgw2 or python3-rgw for simple RGW requests, or just needs the ceph-common package, which pulls in librgw2 transitively. This was reported by prolific community member Neobin on the Proxmox forum [0], and then discussed on the original PR, adding the dependencies [1]. [0]: https://forum.proxmox.com/threads/156433/post-715148 [1]: ceph#52931 (comment) Fixes: https://tracker.ceph.com/issues/68873 Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
Contributor
yuvalif
added a commit
to yuvalif/ceph
that referenced
this pull request
Jan 15, 2025
since it is only a suggestion for debian. this is a regression from: ceph#60666 Fixes: https://tracker.ceph.com/issues/69473 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
14 tasks
yuvalif
added a commit
to yuvalif/ceph
that referenced
this pull request
Jan 16, 2025
since it is only a suggestion for debian. this is a regression from: ceph#60666 Fixes: https://tracker.ceph.com/issues/69473 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One can attach lua scripts as sort of hooks to implement dynamic checks or transformations of RGW requests since Ceph Pacific. Thus, a lua library is now required for base support and optionally one can use the luarocks deployment and management system for Lua modules to use more advanced scripts/modules.
With commit 46500ca ("rgw/test/lua: add lua integration tests suite") the dependency relations got cleaned up, as the respective entries were missing completely from debian/control.
But that commit is pulling in much more than required due to adding the devel package
liblua5.3-devinstead of the library-onlyliblua5.3-0one, and havingluarocksas hard dependency compared to an optional Suggests. Fixing that avoids pulling in a whole build/compiler/autotools/... stack with 65 new packages just when one wants to use librgw2 or python3-rgw for simple RGW requests, or just needs the ceph-common package, which pulls in librgw2 transitively.This was reported by prolific community member Neobin on the Proxmox forum 0, and then discussed on the original PR, adding the dependencies 1.
Fixes: https://tracker.ceph.com/issues/68873
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e