Skip to content

squid: test/scrub: only instruct clean PGs to scrub#61088

Merged
ronen-fr merged 1 commit intoceph:squidfrom
ronen-fr:wip-rf-59437-squid
Jan 12, 2025
Merged

squid: test/scrub: only instruct clean PGs to scrub#61088
ronen-fr merged 1 commit intoceph:squidfrom
ronen-fr:wip-rf-59437-squid

Conversation

@ronen-fr
Copy link
Contributor

@ronen-fr ronen-fr commented Dec 14, 2024

Recent changes to the scrub scheduling mechanism, especially
regarding the 'must_scrub' flag, cause operator scrub commands
issued on a not-clean PG to be rejected - and forgotten.

This commit changes the tests to issue a scrub command only
after the target PG is clean.

Backport of #59437.

Original tracker: https://tracker.ceph.com/issues/64346
Backport tracker: https://tracker.ceph.com/issues/68218

Note:

  1. this is the 2'nd attempt to solve the specific issue in Squid. The original PR that was marked as a solution, squid: qa/standalone/scrub: increase status updates frequency #59974, was not enough.
  2. the current PR may be enough to also fix https://tracker.ceph.com/issues/68833 , but as I wasn't able to reproduce it - it is not guaranteed.

(cherry picked from commit b01c0e9)

Recent changes to the scrub scheduling mechanism, especially
regarding the 'must_scrub' flag, cause operator scrub commands
issued on a not-clean PG to be rejected - and forgotten.

This commit changes the tests to issue a scrub command only
after the target PG is clean.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit b01c0e9)
@github-actions github-actions bot added this to the squid milestone Dec 14, 2024
@ronen-fr ronen-fr changed the title test/scrub: only instruct clean PGs to scrub squid: test/scrub: only instruct clean PGs to scrub Dec 14, 2024
@ronen-fr ronen-fr marked this pull request as ready for review December 14, 2024 08:31
@ronen-fr ronen-fr requested a review from a team as a code owner December 14, 2024 08:31
@Naveenaidu
Copy link
Contributor

Rados approved: https://tracker.ceph.com/issues/69323#note-3

@ronen-fr ronen-fr merged commit 3f13ee1 into ceph:squid Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants