test/scrub: only instruct clean PGs to scrub#59437
Merged
Conversation
ljflores
approved these changes
Aug 30, 2024
Member
ljflores
left a comment
There was a problem hiding this comment.
Fine with me except for a small nit.
qa/standalone/ceph-helpers.sh
Outdated
| ####################################################################### | ||
|
|
||
| ## | ||
| # Predicate checking if the named PG is in state "acrive+clean" |
Member
There was a problem hiding this comment.
Suggested change
| # Predicate checking if the named PG is in state "acrive+clean" | |
| # Predicate checking if the named PG is in state "active+clean" |
Contributor
Author
There was a problem hiding this comment.
I'll fix that. Thanks
Member
|
This should be run through the QA suite before merging to ensure the test is working. |
7d9b5de to
8aa84ad
Compare
Member
|
jenkins test make check |
Contributor
Author
|
The 8aa84ad version is buggy. The test for a clean PG rejects active+clean+inconsistent. FIXED |
8aa84ad to
d9ca5c0
Compare
d9ca5c0 to
656bc1b
Compare
Recent changes to the scrub scheduling mechanism, especially regarding the 'must_scrub' flag, cause operator scrub commands issued on a not-clean PG to be rejected - and forgotten. This commit changes the tests to issue a scrub command only after the target PG is clean. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
656bc1b to
b01c0e9
Compare
Contributor
Author
|
Merging based on multiple Teuthology runs (I had to include the change in all other branches I tested). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to the scrub scheduling mechanism, especially regarding the 'must_scrub' flag, cause operator scrub commands issued on a not-clean PG to be rejected - and forgotten.
This commit changes the tests to issue a scrub command only after the target PG is clean.