squid: mon/LogMonitor: Use generic cluster log level config#61069
Merged
SrinivasaBharath merged 1 commit intoceph:squidfrom Jan 14, 2025
Merged
squid: mon/LogMonitor: Use generic cluster log level config#61069SrinivasaBharath merged 1 commit intoceph:squidfrom
SrinivasaBharath merged 1 commit intoceph:squidfrom
Conversation
We do not control the verbosity of the LogEntry which is getting logged to stderr, graylog and journald. This causes excessive flooding of logs to /var/log, making a filesystem to fill up quickly. Also we have different config variables namely mon_cluster_log_file_level and mon_cluster_log_to_syslog_level to control verbosity at cluster log file and syslog level respectively. Add a generic cluster log level config variable which controls cluster log verbosity for all external entities. Additionally, this patch addresses the regression of `mon_cluster_log_file_level` option which doesn't take effect because of code refactoring of LogMonitor::update_from_paxos (commit : 7c84e06). Fixes: https://tracker.ceph.com/issues/57061 Fixes: https://tracker.ceph.com/issues/57049 Signed-off-by: Prashant D <pdhange@redhat.com> (cherry picked from commit cb0d4a5)
pdvian
approved these changes
Dec 13, 2024
Contributor
pdvian
left a comment
There was a problem hiding this comment.
LGTM. Thank you @shraddhaag.
Contributor
|
Rados approved: https://tracker.ceph.com/issues/69323#note-3 |
Contributor
|
jenkins test api |
Contributor
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/68690
backport of #47502
parent tracker: https://tracker.ceph.com/issues/57061
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh