mon/LogMonitor: Use generic cluster log level config#47502
Merged
Conversation
14 tasks
Contributor
Author
|
jenkins test windows |
sseshasa
approved these changes
Aug 16, 2022
Contributor
|
jenkins retest this please |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Contributor
Author
Sure Sridhar. Let me add a testcase for it. |
de33fb2 to
c396885
Compare
Contributor
Author
|
jenkins test make check |
idryomov
reviewed
Sep 29, 2022
c396885 to
40a7e00
Compare
Contributor
Author
|
Thanks @idryomov. I saw your review comments a bit later. I have added the relevant section in PendingReleaseNotes for removing mon_cluster_log_*_level options. Let me address your review comments for standalone testcases. |
Member
|
jenkins test make check |
sseshasa
reviewed
Oct 20, 2022
Contributor
Author
|
The make check is failing due to tracker#63950. I have opened PR#55070 to fix it. |
Contributor
Member
|
@rzarzynski ACK |
Contributor
|
@pdvian can you please review: /a/yuriw-2024-01-10_19:18:18-rados-wip-yuri3-testing-2024-01-10-0735-distro-default-smithi/7512554 |
Member
|
@pdvian looks like this needs some changes. Feel free to re-add "needs-qa" when this is ready! |
Contributor
Author
Hi @NitzanMordhai, This testcase failed because the ceph cluster log messages were missing the loglevel in human readable format. I have opened a PR#49730 to fix this issue but could not get into main. The cluster logs were printing loglevel in numeric format : instead of : I have re-opened PR#49730 to address this issue. |
Contributor
We do not control the verbosity of the LogEntry which is getting logged to stderr, graylog and journald. This causes excessive flooding of logs to /var/log, making a filesystem to fill up quickly. Also we have different config variables namely mon_cluster_log_file_level and mon_cluster_log_to_syslog_level to control verbosity at cluster log file and syslog level respectively. Add a generic cluster log level config variable which controls cluster log verbosity for all external entities. Additionally, this patch addresses the regression of `mon_cluster_log_file_level` option which doesn't take effect because of code refactoring of LogMonitor::update_from_paxos (commit : 7c84e06). Fixes: https://tracker.ceph.com/issues/57061 Fixes: https://tracker.ceph.com/issues/57049 Signed-off-by: Prashant D <pdhange@redhat.com>
Contributor
Author
|
jenkins test api |
Contributor
|
Not sure it's related: |
Contributor
|
jenkins test api |
Contributor
Contributor
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not control the verbosity of the LogEntry
which is getting logged to stderr, graylog and
journald. This causes excessive flooding of logs
to /var/log, making a filesystem to fill up quickly.
Also we have different config variables namely
mon_cluster_log_file_level and mon_cluster_log_to_syslog_level
to control verbosity at cluster log file and
syslog level respectively. Add a generic cluster log
level config variable which controls cluster log
verbosity for all external entities.
Fixes: https://tracker.ceph.com/issues/57061
Signed-off-by: Prashant D pdhange@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows