reef: mds: batch backtrace updates by pool-id when expiring a log segment#60689
Merged
reef: mds: batch backtrace updates by pool-id when expiring a log segment#60689
Conversation
Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 5639fa2) Conflicts: src/mds/LogSegment.h src/mds/LogSegment.h does not overload "<<" operator, but the log dump is beneficial, so copy out the overload.
Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit e5728c4)
LogSegment::try_to_expire() batches backtrace updations for inodes in dirty_parent_inodes list. If a backtrace update operations fails for one inode due to missing (removed) data pool, which is specially handled by treating the operation as a success, however, the errno (-ENOENT) is stored by the gather context and passed on as the return value to subsequent operations (even for successful backtrace update operations in the same gather context). Fixes: http://tracker.ceph.com/issues/63259 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit d1d3a8c)
…a pool Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 9f27bde)
Contributor
Author
|
jenkins retest this please |
Contributor
Author
|
This PR is under test in https://tracker.ceph.com/issues/69503. |
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Jan 13, 2025
* refs/pull/60689/head: qa/cephfs: add test to verify backtrace update failure on deleted data pool mds: batch backtrace updates by pool-id when expiring a log segment mds: dump log segment in segment expiry callback mds: dump log segment end along with offset
Contributor
|
jenkins test api |
Contributor
|
jenkins test make check |
2 similar comments
Contributor
|
jenkins test make check |
Contributor
|
jenkins test make check |
mchangir
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/68110
backport of #55421
parent tracker: https://tracker.ceph.com/issues/63259
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh