rgw: hiding parquet dependencies upon parquet-select option is off#60621
rgw: hiding parquet dependencies upon parquet-select option is off#60621galsalomon66 merged 1 commit intoceph:mainfrom
Conversation
mkogan1
left a comment
There was a problem hiding this comment.
LGTM,
this fixes the build error with -DWITH_RADOSGW_SELECT_PARQUET=OFF
Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
1150bb6 to
141b675
Compare
| op_ret = -ERR_INVALID_REQUEST; | ||
| } else { | ||
| //status per amount of processed data | ||
| //#ifdef _ARROW_EXIST |
There was a problem hiding this comment.
why adding a comment? or is there a pre-processor manipulating this file before compilation?
There was a problem hiding this comment.
why adding a comment? or is there a pre-processor manipulating this file before compilation?
it's a temporary.
i ran teuthology, it failed, i want to verify it is not related to the recent change.
There was a problem hiding this comment.
What I was trying to say: as this is an approved PR, it probably should not be merged with those comments
There was a problem hiding this comment.
i ran teuthology, it failed, i want to verify it is not related to the recent change.
@galsalomon66 the failures in https://pulpito.ceph.com/gsalomon-2024-11-06_12:03:18-rgw:verify-mask_parquet_dependencies-distro-default-smithi/ look like they're caused by the RGWPSListTopicsOp crashes tracked in https://tracker.ceph.com/issues/68756 (cc @yuvalif)
d962c4f to
141b675
Compare
|
fair to assume we can get this in once the PR checks complete? |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
#62959 (backport into squid) |
upon a user wishes to build RGW without parquet (option is off), the parquet code-lines should be masked.
fixes: https://tracker.ceph.com/issues/68829
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e