qa: reconfigure only the appropriate client auth caps by joscollin · Pull Request #60394 · ceph/ceph

joscollin · 2024-10-18T12:49:20Z

Fix _setup_fs to reconfigure only the appropriate client auth caps,
by avoiding iterating the self.mounts.
Delete unused filesystems in test_perf_stats_stale_metrics_with_multiple_filesystem.

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

joscollin · 2024-10-21T06:04:24Z

jenkins test api

joscollin · 2024-10-21T06:04:33Z

jenkins test make check

joscollin · 2024-10-22T08:34:59Z

jenkins test make check

joscollin · 2024-10-22T11:14:00Z

Tests passed on the (previously) failed branches:
https://pulpito.ceph.com/jcollin-2024-10-22_09:52:45-fs:functional-wip-jcollin-testing-68446-distro-default-smithi/
https://pulpito.ceph.com/jcollin-2024-10-22_10:11:43-fs:functional-wip-jcollin-testing-68001-distro-default-smithi/

Tests passed on main branch too:
https://pulpito.ceph.com/jcollin-2024-10-22_05:23:27-fs:functional-main-distro-default-smithi/

joscollin · 2024-10-22T11:14:15Z

jenkins test make check

joscollin · 2024-10-22T15:13:56Z

jenkins test make check

qa/tasks/cephfs/test_mds_metrics.py

joscollin · 2024-10-28T10:09:52Z

jenkins test make check

rishabh-d-dave

Thanks for incorporating previous changes. Looks much better. Let's put it through QA after next set of changes?

qa/tasks/cephfs/test_mds_metrics.py

neesingh-rh

LGTM

rishabh-d-dave · 2024-10-30T06:06:09Z

Let's put it through QA after next set of changes?

ping @joscollin

rishabh-d-dave · 2024-10-30T06:07:40Z

@joscollin During last review this PR had 3 commits (1 bug fix + 2 improvements). One of the commits is missing this time, Is this intentional?

joscollin · 2024-10-30T06:08:44Z

@joscollin During last review this PR had 3 commits (1 bug fix + 2 improvements). One of the commits is missing this time, Is this intentional?

@rishabh-d-dave
Yes, it's intentional. Even-though it's a good fix, the reviewer doesn't want it to be included in this PR. Please read through the comments and understand it.

rishabh-d-dave · 2024-10-30T06:43:23Z

@joscollin
Anyways, let's put this through QA?

vshankar

6b239a2 is uneeded.

qa/tasks/cephfs/test_mds_metrics.py

joscollin · 2024-10-30T10:32:12Z

6b239a2 is uneeded.

@vshankar
Why? It's better to be fs, right?

joscollin · 2024-11-04T03:40:44Z

6b239a2 is uneeded.

@vshankar Why? It's better to be fs, right?

@vshankar ping.

vshankar · 2024-11-04T04:34:44Z

6b239a2 is uneeded.

@vshankar Why? It's better to be fs, right?

@vshankar ping.

Honestly, the commit really does not add much value apart from the naming change.

joscollin · 2024-11-04T05:20:00Z

@vshankar
My comments are showing pending and not visible to others it seems. Pasting a screenshot here:

neesingh-rh · 2024-11-05T08:39:21Z

@vshankar My comments are showing pending and not visible to others it seems. Pasting a screenshot here:

@joscollin The comments with label pending means they are only visible to the commentor, you should submit the review for publishing it, by selecting on the right corner.

qa/tasks/cephfs/test_mds_metrics.py

* Fix _setup_fs to reconfigure only the appropriate client auth caps, by avoiding iterating the self.mounts. * Delete unused filesystems in test_perf_stats_stale_metrics_with_multiple_filesystem. Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin · 2024-11-05T13:44:49Z

jenkins test api

joscollin · 2024-11-05T13:44:59Z

jenkins test make check

joscollin · 2024-11-06T05:08:49Z

jenkins test make check

* refs/pull/60394/head: qa: reconfigure only the appropriate client auth caps Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

github-actions · 2025-01-06T17:01:46Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

vshankar · 2025-01-15T16:44:01Z

@rishabh-d-dave status of tests?

rishabh-d-dave · 2025-02-07T20:38:33Z

This PR is under test in https://tracker.ceph.com/issues/69872.

rishabh-d-dave · 2025-02-07T20:40:39Z

This PR is under test in https://tracker.ceph.com/issues/69873.

* refs/pull/60394/head: qa: reconfigure only the appropriate client auth caps Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

rishabh-d-dave

QA run was successful. https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-rishabh-testing-20250207204003-debug-4

Requested changes were incorporated.

github-actions bot added cephfs Ceph File System tests labels Oct 18, 2024

joscollin marked this pull request as draft October 18, 2024 12:50

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch from 9d1e558 to e3b3c89 Compare October 18, 2024 13:03

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch from e3b3c89 to 9ebc1cf Compare October 22, 2024 06:16

joscollin marked this pull request as ready for review October 22, 2024 11:26

joscollin marked this pull request as draft October 22, 2024 11:26

joscollin changed the title ~~qa: fix _setup_fs~~ qa: fix _setup_fs in test_mds_metrics.py Oct 22, 2024

joscollin marked this pull request as ready for review October 23, 2024 01:55

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch from 9ebc1cf to 41c5ccb Compare October 23, 2024 04:31

vshankar assigned rishabh-d-dave and neesingh-rh Oct 23, 2024

vshankar requested a review from a team October 23, 2024 07:20

rishabh-d-dave reviewed Oct 28, 2024

View reviewed changes

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch from 41c5ccb to 9244317 Compare October 28, 2024 06:38

neesingh-rh reviewed Oct 28, 2024

View reviewed changes

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

rishabh-d-dave reviewed Oct 28, 2024

View reviewed changes

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch 2 times, most recently from 84156a3 to 6b239a2 Compare October 30, 2024 01:55

neesingh-rh approved these changes Oct 30, 2024

View reviewed changes

vshankar previously requested changes Oct 30, 2024

View reviewed changes

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

qa/tasks/cephfs/test_mds_metrics.py Show resolved Hide resolved

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch 2 times, most recently from 8615ada to 0951bb7 Compare October 30, 2024 10:29

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch from 0951bb7 to 9dda756 Compare November 4, 2024 12:40

joscollin changed the title ~~qa: fix _setup_fs in test_mds_metrics.py~~ qa: reconfigure only the appropriate client auth caps Nov 4, 2024

vshankar reviewed Nov 5, 2024

View reviewed changes

qa/tasks/cephfs/test_mds_metrics.py Outdated Show resolved Hide resolved

joscollin force-pushed the wip-B68446-B68001-get-metrics-fix branch from 9dda756 to 7ac14ca Compare November 5, 2024 09:44

rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Nov 7, 2024

joscollin pushed a commit to joscollin/ceph that referenced this pull request Dec 12, 2024

Merge PR ceph#60394 into wip-rishabh-testing-20241204.130505

5dbe3e2

* refs/pull/60394/head: qa: reconfigure only the appropriate client auth caps Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>

github-actions bot added the stale label Jan 6, 2025

github-actions bot removed the stale label Jan 15, 2025

rishabh-d-dave approved these changes Feb 28, 2025

View reviewed changes

rishabh-d-dave merged commit bd50666 into ceph:main Feb 28, 2025

joscollin deleted the wip-B68446-B68001-get-metrics-fix branch March 4, 2025 04:20

Conversation

joscollin commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

joscollin commented Oct 21, 2024

Uh oh!

joscollin commented Oct 21, 2024

Uh oh!

joscollin commented Oct 22, 2024

Uh oh!

joscollin commented Oct 22, 2024

Uh oh!

joscollin commented Oct 22, 2024

Uh oh!

joscollin commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joscollin commented Oct 28, 2024

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

neesingh-rh left a comment

Choose a reason for hiding this comment

Uh oh!

rishabh-d-dave commented Oct 30, 2024

Uh oh!

rishabh-d-dave commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joscollin commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rishabh-d-dave commented Oct 30, 2024

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joscollin commented Oct 30, 2024

Uh oh!

joscollin commented Nov 4, 2024

Uh oh!

vshankar commented Nov 4, 2024

Uh oh!

joscollin commented Nov 4, 2024

Uh oh!

neesingh-rh commented Nov 5, 2024

Uh oh!

Uh oh!

joscollin commented Nov 5, 2024

Uh oh!

joscollin commented Nov 5, 2024

Uh oh!

joscollin commented Nov 6, 2024

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

vshankar commented Jan 15, 2025

Uh oh!

rishabh-d-dave commented Feb 7, 2025

Uh oh!

rishabh-d-dave commented Feb 7, 2025

Uh oh!

rishabh-d-dave left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

joscollin commented Oct 18, 2024 •

edited

Loading

rishabh-d-dave commented Oct 30, 2024 •

edited

Loading

joscollin commented Oct 30, 2024 •

edited

Loading