Skip to content

reef: mgr/vol : shortening the name of helper method#60369

Merged
hkadam134 merged 1 commit intoceph:reeffrom
neesingh-rh:wip-68590-reef
Feb 18, 2025
Merged

reef: mgr/vol : shortening the name of helper method#60369
hkadam134 merged 1 commit intoceph:reeffrom
neesingh-rh:wip-68590-reef

Conversation

@neesingh-rh
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/68590


backport of #58292
parent tracker: https://tracker.ceph.com/issues/66815

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

Fixes: https://tracker.ceph.com/issues/66815
Introduced by:ceph#55838 (comment)
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 6ae0024)
@vshankar
Copy link
Contributor

vshankar commented Jan 3, 2025

jenkins retest this please

@hkadam134
Copy link
Contributor

QA Tracker : https://tracker.ceph.com/issues/69534

@ljflores
Copy link
Member

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented Feb 3, 2025

QA Tracker : https://tracker.ceph.com/issues/69534

@hkadam134 status of this run? I see you have assigned the above tracker to me but it's unclear what you need from me.

@hkadam134
Copy link
Contributor

QA Tracker: https://tracker.ceph.com/issues/69534

@hkadam134 status of this run? I see you have assigned the above tracker to me but it's unclear what you need from me.

Hey Venky , I pinged you on Slack to review the triaged QA Runs to ensure the issues are unrelated to the fixes.
Sharing the link again here--
https://pad.ceph.com/p/hyelloji-2025-01-15_07_12_26-fs-wip-hemanth1

@ljflores
Copy link
Member

ljflores commented Feb 6, 2025

@ljflores
Copy link
Member

ljflores commented Feb 6, 2025

jenkins test make check

@hkadam134
Copy link
Contributor

@batrick – Two new issues were found during testing:
https://tracker.ceph.com/issues/69898
https://tracker.ceph.com/issues/69899

Could you review and confirm whether these are unrelated to the fix? Based on your confirmation, I'll proceed with merging the PR.

The rest of the test runs look good. - https://pad.ceph.com/p/hyelloji-2025-01-15_07_12_26-fs-wip-hemanth1
Wiki - https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-hemanth1-testing-2025-01-13-1558-reef

@vshankar
Copy link
Contributor

@batrick – Two new issues were found during testing: https://tracker.ceph.com/issues/69898 https://tracker.ceph.com/issues/69899

Could you review and confirm whether these are unrelated to the fix? Based on your confirmation, I'll proceed with merging the PR.

The rest of the test runs look good. - https://pad.ceph.com/p/hyelloji-2025-01-15_07_12_26-fs-wip-hemanth1 Wiki - https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-hemanth1-testing-2025-01-13-1558-reef

I have request @mchangir to have a look at the run wiki and the results.

@hkadam134
Copy link
Contributor

Milind confirmed that the failures documented in the Wiki are unrelated to the PRs selected for this QA run. SO, we are good to merge.
https://tracker.ceph.com/issues/69534#note-15

@vshankar - Need Reviewers' Approval to merge the PR.

@vshankar
Copy link
Contributor

Milind confirmed that the failures documented in the Wiki are unrelated to the PRs selected for this QA run. SO, we are good to merge. https://tracker.ceph.com/issues/69534#note-15

@vshankar - Need Reviewers' Approval to merge the PR.

Thanks @hkadam134 @mchangir - nice work!

@hkadam134 hkadam134 merged commit edc9202 into ceph:reef Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants