mgr/vol : shortening the name of helper method#58292
Conversation
|
Jenkins retest this please |
|
@neesingh-rh needs signed off by tag. |
097a584 to
74cb7eb
Compare
rishabh-d-dave
left a comment
There was a problem hiding this comment.
LGTM. IMO we should have a tracker ticket for this and backport it, so that future backports won't have to search for the commit for this change and then backport it during conflicts.
74cb7eb to
9bff472
Compare
I have created a tracker and added it in the PR description. |
Fixes: https://tracker.ceph.com/issues/66815 Introduced by:ceph#55838 (comment) Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
9bff472 to
6ae0024
Compare
|
jenkins test api |
|
@vshankar @rishabh-d-dave I think we can proceed with this PR. There's just a small change. |
I was likely waiting for jenkins tests to pass and then this got sidelined. Thx for the nudge. |
Introduced by: #55838 (comment) and #55838 (comment)
Fixes: https://tracker.ceph.com/issues/66815
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e