Merged
Conversation
batrick
requested changes
Oct 9, 2024
Member
batrick
left a comment
There was a problem hiding this comment.
otherwise LGTM
I assume these relatively simple changes are not the source of the 2x speedup you mentioned for the MDS?
Member
Author
No, not yet; these are just micro optimizations that will be hard to measure; hundreds of micro optimizations may be measurable eventually. But I have a bunch of patches that will make a larger impact, but not yet submitted. |
An iterator is just a pointer, and passing it by reference means we pass a pointer to a pointer, which is useless overhead. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
When erasing items from a linked list while iterating it, it is good practice (and safer and sometimes faster) to use the erase() return value instead of incrementing the iterator. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
7bca654 to
4fbb678
Compare
batrick
approved these changes
Oct 9, 2024
Member
|
jenkins test api |
Member
|
jenkins test make check arm64 |
2 similar comments
Member
|
jenkins test make check arm64 |
Member
|
jenkins test make check arm64 |
Member
|
jenkins test make check arm64 |
Member
|
This PR is under test in https://tracker.ceph.com/issues/68629. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Oct 19, 2024
* refs/pull/60214/head: mds/MDCache: use `auto` mds/CDir: use the erase() return value mds/MDCache: remove unnecessary empty() check mds/MDCache: use the erase() return value mds/MDCache: pass iterator by value
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDS-specific parts of #60175 (split upon @batrick's request)
Checklist