reef: mds: misc fixes for MDSAuthCaps code#60207
Merged
Conversation
Once the caller_gid is matched it will make no sense to do the following caller gid list check. Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit bd3e019)
Just in case the 'target_path' is tailed with '/' it may fail to match the 'path', such as in case 'path=/foo/' and 'target_path=/foo' it will fail. Just try to remove the tailing '/' from 'target_path' and then also we can simplify the code to make it more readable. Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit cd706e4)
Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit 516b099)
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
Contributor
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69503. |
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Jan 13, 2025
* refs/pull/60207/head: test/libcephfs: add test case for slash tailing path for access mds: fix and improve MDSCapMatch::match_path() mds: skip uneccessary caller gid list check
Contributor
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
mchangir
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/68455
backport of #54381
parent tracker: https://tracker.ceph.com/issues/68453
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh