msg/async/ProtocolV2: pass desc as C string to write()#60106
Merged
msg/async/ProtocolV2: pass desc as C string to write()#60106
desc as C string to write()#60106Conversation
Member
Author
|
"Identified problems Yet another bogus CI failure. |
batrick
requested changes
Oct 4, 2024
Member
Author
|
@batrick, do you still believe |
All callers really pass a C string literal, and declaring a `std::string` parameter will implicitly create two `std::string` instances: one on the caller's stack, and another one inside write() as parameter to the continuation lambda. This causes considerable and unnecessary overhead. Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
3859fa9 to
966920e
Compare
batrick
approved these changes
Oct 7, 2024
Member
|
jenkins test api |
Member
|
jenkins test make check arm64 |
Member
|
jenkins test api |
1 similar comment
Member
|
jenkins test api |
rzarzynski
approved these changes
Oct 13, 2024
Member
|
This PR is under test in https://tracker.ceph.com/issues/68629. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Oct 19, 2024
* refs/pull/60106/head: msg/async/ProtocolV2: pass `desc` as `std::string_view` to write()
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All callers really pass a C string literal, and declaring a
std::stringparameter will implicitly create twostd::stringinstances: one on the caller's stack, and another one inside write() as parameter to the continuation lambda. This causes considerable and unnecessary overhead.This patch reduces the code size by nearly 2 kB.
Checklist