Skip to content

mgr/status: Fix 'fs status' json output#59699

Merged
vshankar merged 2 commits intoceph:mainfrom
kotreshhr:fix-ceph-status-json
Oct 7, 2024
Merged

mgr/status: Fix 'fs status' json output#59699
vshankar merged 2 commits intoceph:mainfrom
kotreshhr:fix-ceph-status-json

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Sep 10, 2024

Fix rank field of standby-replay mds daemon in 'ceph fs status'
json output. The rank field for standby-replay mds daemons
were incorrect. It should be of the format '{rank}-s',
where {rank} is the active mds which the standby-replay is
following.

Fixes: https://tracker.ceph.com/issues/67978
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@kotreshhr kotreshhr added the cephfs Ceph File System label Sep 10, 2024
@kotreshhr kotreshhr requested a review from a team September 10, 2024 08:57
@kotreshhr kotreshhr requested a review from a team September 11, 2024 06:18
Fix rank field of standby-replay mds daemon in 'ceph fs status'
json output. The rank field for standby-replay mds daemons
were incorrect. It should be of the format '{rank}-s',
where {rank} is the active mds which the standby-replay is
following.

Fixes: https://tracker.ceph.com/issues/67978
Signed-off-by: Kotresh HR <khiremat@redhat.com>
@kotreshhr
Copy link
Contributor Author

jenkins test api

@kotreshhr kotreshhr closed this Sep 11, 2024
@kotreshhr kotreshhr reopened this Sep 11, 2024
@kotreshhr
Copy link
Contributor Author

Sorry, closed this PR by accident. Reopend it.

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/68092.

joscollin pushed a commit to joscollin/ceph that referenced this pull request Sep 23, 2024
* refs/pull/59699/head:
	mgr/status: Fix 'fs status' json output
	qa: Add test for 'fs status' in standby-replay mds setup

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 9f1311f into ceph:main Oct 7, 2024
joscollin pushed a commit to joscollin/ceph that referenced this pull request Oct 11, 2024
* refs/pull/59699/head:
	mgr/status: Fix 'fs status' json output
	qa: Add test for 'fs status' in standby-replay mds setup

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants