Skip to content

qa/erasure-code: add new teuthology isa configs#59679

Merged
SrinivasaBharath merged 1 commit intomainfrom
add-new-ec-plugins-for-qa
Jan 29, 2025
Merged

qa/erasure-code: add new teuthology isa configs#59679
SrinivasaBharath merged 1 commit intomainfrom
add-new-ec-plugins-for-qa

Conversation

@jamiepryde
Copy link
Contributor

Signed-off-by: Jamie Pryde jamiepry@uk.ibm.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
@jamiepryde jamiepryde self-assigned this Sep 9, 2024
@jamiepryde jamiepryde requested a review from a team as a code owner September 9, 2024 20:57
@jamiepryde
Copy link
Contributor Author

jenkins test api

Copy link
Member

@markhpc markhpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't done anything with Teuthology in forever so I can't comment on the exact specifics of the yaml here, but assuming it runs I see no reason no to add this.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Dec 30, 2024
@@ -0,0 +1,26 @@
tasks:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jamiepryde, apologies for the delayed review. Can you check out this failure that happened on the new isa plugin added here? We have seen these types of failures before but it would be good to confirm this isn't a regression.

https://pulpito.ceph.com/yuriw-2024-11-20_16:11:55-rados-wip-yuri3-testing-2024-11-14-0857-distro-default-smithi/8001581/
/a/yuriw-2024-11-20_16:11:55-rados-wip-yuri3-testing-2024-11-14-0857-distro-default-smithi/8001581

2024-11-20T19:00:06.714 INFO:tasks.ceph.ceph_manager.ceph:{'pgid': '2.5', 'version': "0'0", 'reported_seq': 2054, 'reported_epoch': 1337, 'state': 'active+undersized', 'last_fresh': '2024-11-20T19:00:03.957756+0000', 'last_change': '2024-11-20T18:29:28.249181+0000', 'last_active': '2024-11-20T19:00:03.957756+0000', 'last_peered': '2024-11-20T19:00:03.957756+0000', 'last_clean': '2024-11-20T18:29:26.287553+0000', 'last_became_active': '2024-11-20T18:29:28.249181+0000', 'last_became_peered': '2024-11-20T18:29:28.249181+0000', 'last_unstale': '2024-11-20T19:00:03.957756+0000', 'last_undegraded': '2024-11-20T19:00:03.957756+0000', 'last_fullsized': '2024-11-20T18:29:28.245635+0000', 'mapping_epoch': 849, 'log_start': "0'0", 'ondisk_log_start': "0'0", 'created': 25, 'last_epoch_clean': 796, 'parent': '0.0', 'parent_split_bits': 0, 'last_scrub': "0'0", 'last_scrub_stamp': '2024-11-20T18:23:25.397999+0000', 'last_deep_scrub': "0'0", 'last_deep_scrub_stamp': '2024-11-20T18:15:26.541052+0000', 'last_clean_scrub_stamp': '2024-11-20T18:23:25.397999+0000', 'objects_scrubbed': 0, 'log_size': 0, 'log_dups_size': 0, 'ondisk_log_size': 0, 'stats_invalid': False, 'dirty_stats_invalid': False, 'omap_stats_invalid': False, 'hitset_stats_invalid': False, 'hitset_bytes_stats_invalid': False, 'pin_stats_invalid': False, 'manifest_stats_invalid': False, 'snaptrimq_len': 0, 'last_scrub_duration': 1, 'scrub_schedule': 'periodic scrub scheduled @ 2024-11-20T19:00:23.351348+0000', 'scrub_duration': 3, 'objects_trimmed': 0, 'snaptrim_duration': 0.001178619, 'stat_sum': {'num_bytes': 0, 'num_objects': 0, 'num_object_clones': 0, 'num_object_copies': 0, 'num_objects_missing_on_primary': 0, 'num_objects_missing': 0, 'num_objects_degraded': 0, 'num_objects_misplaced': 0, 'num_objects_unfound': 0, 'num_objects_dirty': 0, 'num_whiteouts': 0, 'num_read': 0, 'num_read_kb': 0, 'num_write': 0, 'num_write_kb': 0, 'num_scrub_errors': 0, 'num_shallow_scrub_errors': 0, 'num_deep_scrub_errors': 0, 'num_objects_recovered': 0, 'num_bytes_recovered': 0, 'num_keys_recovered': 0, 'num_objects_omap': 0, 'num_objects_hit_set_archive': 0, 'num_bytes_hit_set_archive': 0, 'num_flush': 0, 'num_flush_kb': 0, 'num_evict': 0, 'num_evict_kb': 0, 'num_promote': 0, 'num_flush_mode_high': 0, 'num_flush_mode_low': 0, 'num_evict_mode_some': 0, 'num_evict_mode_full': 0, 'num_objects_pinned': 0, 'num_legacy_snapsets': 0, 'num_large_omap_objects': 0, 'num_objects_manifest': 0, 'num_omap_bytes': 0, 'num_omap_keys': 0, 'num_objects_repaired': 0}, 'up': [7], 'acting': [7], 'avail_no_missing': ['7'], 'object_location_counts': [], 'blocked_by': [], 'up_primary': 7, 'acting_primary': 7, 'purged_snaps': []}
2024-11-20T19:00:06.715 INFO:tasks.thrashosds.thrasher:Traceback (most recent call last):
  File "/home/teuthworker/src/github.com_ceph_ceph-c_aec760e0fabcca6ad826f66c77e5a4b1dfe7585f/qa/tasks/ceph_manager.py", line 192, in wrapper
    return func(self)
  File "/home/teuthworker/src/github.com_ceph_ceph-c_aec760e0fabcca6ad826f66c77e5a4b1dfe7585f/qa/tasks/ceph_manager.py", line 1486, in _do_thrash
    self.test_map_discontinuity()
  File "/home/teuthworker/src/github.com_ceph_ceph-c_aec760e0fabcca6ad826f66c77e5a4b1dfe7585f/qa/tasks/ceph_manager.py", line 1264, in test_map_discontinuity
    self.ceph_manager.wait_for_clean(
  File "/home/teuthworker/src/github.com_ceph_ceph-c_aec760e0fabcca6ad826f66c77e5a4b1dfe7585f/qa/tasks/ceph_manager.py", line 2930, in wait_for_clean
    assert time.time() - start < timeout, \
AssertionError: wait_for_clean: failed before timeout expired

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to have this one retested in isolation since the error is kind of ambiguous and not obviously related to these changes. That will help narrow down if we can merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ljflores , thanks for taking a look. The failure message doesn't look like it would be related to my changes. I did do a teuthology run with the new ISA configs a while ago and that run passed. I haven't tested the other PR #60246 using teuthology though.

@Naveenaidu
Copy link
Contributor

@SrinivasaBharath SrinivasaBharath merged commit ac9d18c into main Jan 29, 2025
@SrinivasaBharath SrinivasaBharath deleted the add-new-ec-plugins-for-qa branch January 29, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants