Skip to content

squid: test: test_rados_tools compare output without trimming newline#59625

Merged
SrinivasaBharath merged 1 commit intoceph:squidfrom
NitzanMordhai:wip-67914-squid
Jan 13, 2025
Merged

squid: test: test_rados_tools compare output without trimming newline#59625
SrinivasaBharath merged 1 commit intoceph:squidfrom
NitzanMordhai:wip-67914-squid

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Sep 5, 2024

backport tracker: https://tracker.ceph.com/issues/67914

backport of #59165
parent tracker: https://tracker.ceph.com/issues/67419

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@NitzanMordhai
test: test_rados_tools compare output without trimming newline
f2e56bd 
Fixes: https://tracker.ceph.com/issues/67419
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit 0c423e1)
@NitzanMordhai NitzanMordhai requested a review from a team as a code owner September 5, 2024 16:42
@NitzanMordhai NitzanMordhai added this to the squid milestone Sep 5, 2024
@github-actions
Copy link

github-actions bot commented Nov 26, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 26, 2024
@ljflores
Copy link
Member

ljflores commented Dec 12, 2024

jenkins test api

@github-actions github-actions bot removed the stale label Dec 12, 2024
rzarzynski
rzarzynski reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need to trim the new line at getxattr as the reference is put the the following way:

    echo -n fooval > $V1

@Naveenaidu
Copy link
Contributor

Naveenaidu commented Jan 12, 2025

Rados approved: https://tracker.ceph.com/issues/69323#note-3

@SrinivasaBharath SrinivasaBharath merged commit 56ff881 into ceph:squid Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzarzynski rzarzynski rzarzynski approved these changes

@ljflores ljflores ljflores approved these changes

Assignees

No one assigned

Labels

core needs-qa tests tools wip-bharath6-testing

Projects

None yet

Milestone

squid

Development

Successfully merging this pull request may close these issues.

5 participants

@NitzanMordhai @ljflores @Naveenaidu @rzarzynski @SrinivasaBharath