Skip to content

test: test_rados_tools compare output without trimming newline#59165

Merged
NitzanMordhai merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-test-rados-tools-newline-trim
Aug 20, 2024
Merged

test: test_rados_tools compare output without trimming newline#59165
NitzanMordhai merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-test-rados-tools-newline-trim

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented Aug 12, 2024

Fixes: https://tracker.ceph.com/issues/67419

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@NitzanMordhai NitzanMordhai requested a review from a team as a code owner August 12, 2024 11:29
@ljflores
Copy link
Member

jenkins test make check

@NitzanMordhai
Copy link
Contributor Author

@yuriw
Copy link
Contributor

yuriw commented Aug 19, 2024

@NitzanMordhai @ljflores pls merge when all checks passed
ref: https://tracker.ceph.com/issues/67523

@yuriw
Copy link
Contributor

yuriw commented Aug 19, 2024

jenkins test make check

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Aug 19, 2024

jenkins test make check

@NitzanMordhai NitzanMordhai merged commit 182d803 into ceph:main Aug 20, 2024
@NitzanMordhai NitzanMordhai deleted the wip-nitzan-test-rados-tools-newline-trim branch August 20, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants