Skip to content

squid: qa: barbican: restrict python packages with upper-constraints#59327

Merged
yuriw merged 1 commit intoceph:squidfrom
cbodley:wip-67620-squid
Mar 3, 2025
Merged

squid: qa: barbican: restrict python packages with upper-constraints#59327
yuriw merged 1 commit intoceph:squidfrom
cbodley:wip-67620-squid

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Aug 19, 2024

backport tracker: https://tracker.ceph.com/issues/67620


backport of #59241
parent tracker: https://tracker.ceph.com/issues/67444

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

We install barbican by doing a pip install directly on the
cloned git repository but we don't honor the upper-constraints
from the OpenStack Requirements project that handles what
versions is supported.

This changes the pip install command that we issue when
installing barbican to honor the requirements for the
version (derived from the branch) that we use, in
this case it's the 2023.1 release upper-constraints [1].

This prevents us from pulling in untested Python packages.

This only updates Barbican because for the Keystone job
we dont directly issue pip but install using tox using the
`venv` environment which already by default sets the
constraints as you can see in [2].

[1] https://releases.openstack.org/constraints/upper/2023.1
[2] https://github.com/openstack/keystone/blob/stable/2023.1/tox.ini#L12

Fixes: https://tracker.ceph.com/issues/67444
Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit bbcb820)
@cbodley cbodley requested a review from a team as a code owner August 19, 2024 17:23
@cbodley cbodley added this to the squid milestone Aug 19, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 26, 2024
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@ronen-fr
Copy link
Contributor

@yuriw yuriw merged commit a644765 into ceph:squid Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants