qa: barbican: restrict python packages with upper-constraints#59241
Merged
qa: barbican: restrict python packages with upper-constraints#59241
Conversation
cbodley
reviewed
Aug 15, 2024
1fa6b09 to
55c6d70
Compare
We install barbican by doing a pip install directly on the cloned git repository but we don't honor the upper-constraints from the OpenStack Requirements project that handles what versions is supported. This changes the pip install command that we issue when installing barbican to honor the requirements for the version (derived from the branch) that we use, in this case it's the 2023.1 release upper-constraints [1]. This prevents us from pulling in untested Python packages. This only updates Barbican because for the Keystone job we dont directly issue pip but install using tox using the `venv` environment which already by default sets the constraints as you can see in [2]. [1] https://releases.openstack.org/constraints/upper/2023.1 [2] https://github.com/openstack/keystone/blob/stable/2023.1/tox.ini#L12 Fixes: https://tracker.ceph.com/issues/67444 Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
55c6d70 to
bbcb820
Compare
Contributor
Author
|
@cbodley any luck with this one? (pushed a commit msg change to include signed-off-by) |
cbodley
approved these changes
Aug 19, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We install barbican by doing a pip install directly on the cloned git repository but we don't honor the upper-constraints from the OpenStack Requirements project that handles what versions is supported.
This changes the pip install command that we issue when installing barbican to honor the requirements for the version (derived from the branch) that we use, in
this case it's the 2023.1 release upper-constraints [1].
This prevents us from pulling in untested Python packages.
This only updates Barbican because for the Keystone job we dont directly issue pip but install using tox using the
venvenvironment which already by default sets the constraints as you can see in [2].[1] https://releases.openstack.org/constraints/upper/2023.1
[2] https://github.com/openstack/keystone/blob/stable/2023.1/tox.ini#L12
Fixes: https://tracker.ceph.com/issues/67444
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e