tools/rados: Fix extra NL in getxattr#59025
Merged
Conversation
Recent code refactor caused extra "std::endl" output. Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
benhanokh
approved these changes
Aug 5, 2024
ronen-fr
approved these changes
Aug 5, 2024
rzarzynski
approved these changes
Aug 5, 2024
14 tasks
cbodley
approved these changes
Aug 6, 2024
vshankar
approved these changes
Aug 6, 2024
Contributor
|
Just FYI - https://tracker.ceph.com/issues/67336 |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/67368. |
rishabh-d-dave
approved these changes
Aug 13, 2024
Contributor
rishabh-d-dave
left a comment
There was a problem hiding this comment.
@aclamk IMO, it'll be nice to add introduced-by tag in commit and have tracker ticket for this so that this commit can also be backported. The commit that introduced this issue has been backported to Squid and will be to Reef. See: https://tracker.ceph.com/issues/66286.
vshankar
approved these changes
Aug 14, 2024
Contributor
joscollin
pushed a commit
to joscollin/ceph
that referenced
this pull request
Aug 14, 2024
* refs/pull/59025/head: tools/rados: Fix extra NL in getxattr Reviewed-by: Ronen Friedman <rfriedma@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Casey Bodley <cbodley@redhat.com> Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com> Reviewed-by: Gabriel Benhanokh <gbenhano@redhat.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent code refactor caused extra "std::endl" output.
Detected by teuthology:
https://pulpito.ceph.com/akupczyk-2024-08-02_13:56:25-rados-aclamk-testing-phoebe-2024-08-01-1249-distro-default-smithi/7832308/
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e