cephfs_mirror: 'ceph fs snapshot mirror ls' command by joscollin · Pull Request #58966 · ceph/ceph

joscollin · 2024-07-31T14:39:42Z

Fixes: https://tracker.ceph.com/issues/67292

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

joscollin · 2024-08-01T09:18:25Z

Test passed: https://pulpito.ceph.com/jcollin-2024-08-01_08:52:09-fs:mirror-wip-jcollin-testing-67292-distro-default-smithi/

src/pybind/mgr/mirroring/fs/snapshot_mirror.py

qa/tasks/cephfs/test_mirroring.py

joscollin · 2024-08-05T15:07:00Z

https://pulpito.ceph.com/jcollin-2024-08-05_13:04:46-fs:mirror-wip-jcollin-testing-67292-distro-default-smithi/

src/pybind/mgr/mirroring/module.py

joscollin · 2024-08-08T05:01:50Z

jenkins test make check

joscollin · 2024-08-09T04:18:50Z

jenkins test make check

joscollin · 2024-08-20T04:25:45Z

jenkins test make check arm64

vshankar · 2024-08-20T04:28:25Z

This PR is under test in https://tracker.ceph.com/issues/67626.

joscollin · 2024-08-25T00:43:14Z

jenkins test make check arm64

vshankar

PTAL at the failure @joscollin

qa/tasks/cephfs/test_mirroring.py

* refs/pull/58966/head: qa: test 'ceph fs snapshot mirror ls' command doc: update docs for 'fs snapshot mirror ls' command cephfs_mirror: ceph fs snapshot mirror ls command Reviewed-by: Venky Shankar <vshankar@redhat.com>

Fixes: https://tracker.ceph.com/issues/67292 Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin · 2024-08-30T02:45:46Z

jenkins test windows

joscollin · 2024-08-30T03:30:15Z

@vshankar Updated the PR and it's ready for review/qa again.

joscollin · 2024-09-10T04:36:07Z

jenkins test make check arm64

vshankar · 2024-09-17T04:40:30Z

This PR is under test in https://tracker.ceph.com/issues/68092.

* refs/pull/58966/head: qa: test 'ceph fs snapshot mirror ls' command doc: update docs for 'fs snapshot mirror ls' command cephfs_mirror: ceph fs snapshot mirror ls command Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

vshankar

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20240917043942-debug

* refs/pull/58966/head: qa: test 'ceph fs snapshot mirror ls' command doc: update docs for 'fs snapshot mirror ls' command cephfs_mirror: ceph fs snapshot mirror ls command Reviewed-by: Dhairya Parmar <dparmar@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>

github-actions bot added the pybind label Jul 31, 2024

joscollin added cephfs Ceph File System and removed pybind labels Jul 31, 2024

joscollin force-pushed the wip-F67292-snapshot-mirror-ls branch from dd6176a to 98874a4 Compare August 1, 2024 06:10

joscollin requested a review from a team as a code owner August 1, 2024 06:10

github-actions bot added documentation pybind tests labels Aug 1, 2024

joscollin requested a review from a team August 1, 2024 09:18

vshankar requested changes Aug 5, 2024

View reviewed changes

src/pybind/mgr/mirroring/fs/snapshot_mirror.py Outdated Show resolved Hide resolved

qa/tasks/cephfs/test_mirroring.py Outdated Show resolved Hide resolved

joscollin force-pushed the wip-F67292-snapshot-mirror-ls branch from 98874a4 to 185646e Compare August 5, 2024 10:18

joscollin changed the title ~~cephfs_mirror: ceph fs snapshot mirror ls command~~ cephfs_mirror: 'ceph fs snapshot mirror ls' command Aug 5, 2024

neesingh-rh reviewed Aug 7, 2024

View reviewed changes

src/pybind/mgr/mirroring/module.py Outdated Show resolved Hide resolved

joscollin force-pushed the wip-F67292-snapshot-mirror-ls branch from 185646e to bc219a9 Compare August 7, 2024 12:16

joscollin requested review from neesingh-rh and vshankar August 8, 2024 05:01

vshankar approved these changes Aug 8, 2024

View reviewed changes

vshankar added the wip-vshankar-testing2 label Aug 8, 2024

dparmar18 approved these changes Aug 20, 2024

View reviewed changes

vshankar requested changes Aug 28, 2024

View reviewed changes

qa/tasks/cephfs/test_mirroring.py Show resolved Hide resolved

qa/tasks/cephfs/test_mirroring.py Outdated Show resolved Hide resolved

vshankar removed the wip-vshankar-testing2 label Aug 28, 2024

cephfs_mirror: ceph fs snapshot mirror ls command

1c07a39

Fixes: https://tracker.ceph.com/issues/67292 Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin added 2 commits August 29, 2024 17:19

doc: update docs for 'fs snapshot mirror ls' command

e60d82a

Fixes: https://tracker.ceph.com/issues/67292 Signed-off-by: Jos Collin <jcollin@redhat.com>

qa: test 'ceph fs snapshot mirror ls' command

6b24da7

Fixes: https://tracker.ceph.com/issues/67292 Signed-off-by: Jos Collin <jcollin@redhat.com>

joscollin force-pushed the wip-F67292-snapshot-mirror-ls branch from bc219a9 to 6b24da7 Compare August 30, 2024 00:03

joscollin added the needs-qa label Sep 2, 2024

vshankar added the wip-vshankar-testing4 label Sep 10, 2024

vshankar approved these changes Oct 7, 2024

View reviewed changes

vshankar merged commit eb21831 into ceph:main Oct 7, 2024

vshankar removed the wip-vshankar-testing4 label Oct 7, 2024

joscollin deleted the wip-F67292-snapshot-mirror-ls branch October 8, 2024 03:15

This was referenced Oct 8, 2024

squid: cephfs_mirror: 'ceph fs snapshot mirror ls' command #60177

Merged

reef: cephfs_mirror: 'ceph fs snapshot mirror ls' command #60178

Merged

quincy: cephfs_mirror: 'ceph fs snapshot mirror ls' command #60179

Closed

Conversation

joscollin commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

joscollin commented Aug 1, 2024

Uh oh!

Uh oh!

Uh oh!

joscollin commented Aug 5, 2024

Uh oh!

Uh oh!

joscollin commented Aug 8, 2024

Uh oh!

joscollin commented Aug 9, 2024

Uh oh!

joscollin commented Aug 20, 2024

Uh oh!

vshankar commented Aug 20, 2024

Uh oh!

joscollin commented Aug 25, 2024

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joscollin commented Aug 30, 2024

Uh oh!

joscollin commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joscollin commented Sep 10, 2024

Uh oh!

vshankar commented Sep 17, 2024

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joscollin commented Jul 31, 2024 •

edited

Loading

joscollin commented Aug 30, 2024 •

edited

Loading