Conversation
Move fmt sub module branch to https://github.com/ceph/fmt/commits/wip-fmt-11.0.2/ Signed-off-by: Matan Breizman <mbreizma@redhat.com>
|
This will require few adjustments, will update this PR once I manage to build. |
|
no objection, but is this something we could reasonably backport all the way to quincy? we appear to have several constraints from fmt, clang, and gcc versions and need to satisfy those on all releases for example, the crimson builds for shaman using gcc-13 don't appear to have this issue |
Probably not, this will require a too drastic change.
Are you suggesting that upgrading compilers will be easier? |
@Matan-B hehe, i wouldn't say "easy" based on the mess i've made with #58384 in the short term, i think the easiest way to fix 'make check' is to uninstall gcc-12 stuff from all of the ubuntu nodes in jenkins i just don't want to end up stuck there, or we'll never get past gcc-11. i've been trying to raise awareness about this in https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/LNMXUFBMFXHIXX334DYOMW5K4PYN4YIM/, but maybe that needs to wait until we've shipped squid. we might just wait until the builders upgrade to ubuntu 24.04 (https://tracker.ceph.com/issues/66914) and go straight to gcc-13 |
The point is libstd++-12-dev and libgcc-12-dev, I tried to uninstall them on ARM CI servers, works fine. Unlike ceph-build, for 'make check', we use clang first, not gcc. |
|
Will work on the adjustments in this PR - #58990 |
|
Closing for #58990 |
Move fmt sub module branch to https://github.com/ceph/fmt/commits/wip-fmt-11.0.2/
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e