build: bump gcc version from 11->12 by cbodley · Pull Request #58384 · ceph/ceph

cbodley · 2024-07-01T21:24:18Z

pushing a draft to see what breaks

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

tchaikov · 2024-07-01T23:35:22Z

ceph.spec.in

-%if 0%{?enable_devtoolset11:1}
-%enable_devtoolset11
+%if 0%{?enable_devtoolset12:1}
+%enable_devtoolset12


where do we install gts-12? if we can assume gcc >=12 is available, we might want to drop this line.

okay. assuming we have the corresponding macro installed, we should have it.

i think we'd expect install-deps.sh or ceph-build to install this where necessary

without ceph-build changes, i think it'll be hard to actually test this in ci

@tchaikov can you help me understand what installs gts-13 for #55886?

nevermind; setting gts_version=12 above causes us to install gcc-toolset-%{gts_version}-build which apparently makes this %enable_devtoolset12 thing available

i see that working for the rpm builds in https://shaman.ceph.com/builds/ceph/wip-gcc-12/1b854c2b0aaaebb77f92763f72bc7dff83166319/

adamemerson · 2024-07-02T18:13:30Z

jenkins test make check arm64

adamemerson · 2024-07-02T18:15:46Z

I'd really like to advocate strongly That we stop using Clang for make check. Clang 14 in particular rejects valid code that comparable GCC and later Clang don't, and I don't think the advantage in warnings exists against newer GCCs.

cbodley · 2024-07-02T21:23:33Z

I don't think the advantage in warnings exists against newer GCCs

how new are we talking? does gcc 12 qualify?

I'd really like to advocate strongly That we stop using Clang for make check.

warnings aside, i think 'make check' would provide more value if it ran unit tests produced by the same toolchain that we're using for our release builds

i like the idea of having clang coverage too, as long as we keep the clang version up to date

if we had unlimited resources, i'd also take a matrix of builds for every gcc version we're trying to support

adamemerson · 2024-07-02T21:34:43Z

I don't think the advantage in warnings exists against newer GCCs

how new are we talking? does gcc 12 qualify?

Just that in general I've noticed that GCC seems to pick up Clang's warnings a release or two after Clang comes out with them.

I'd really like to advocate strongly That we stop using Clang for make check.

warnings aside, i think 'make check' would provide more value if it ran unit tests produced by the same toolchain that we're using for our release builds

I'd agree with that, too.

i like the idea of having clang coverage too, as long as we keep the clang version up to date

if we had unlimited resources, i'd also take a matrix of builds for every gcc version we're trying to support

tchaikov · 2024-07-02T23:29:44Z

I'd really like to advocate strongly That we stop using Clang for make check.

the reason why we switched to Clang for running make check was that it was more picky. and was able to surface some potential issues that GCC couldn't. and its error messages were more readable sometimes.

Clang 14 in particular rejects valid code that comparable GCC and later Clang don't, and I don't think the advantage in warnings exists against newer GCCs.

probably it's time to use a newer Clang, like Clang-18?

ronen-fr · 2024-07-04T13:05:08Z

Clang 14 in particular rejects valid code that comparable GCC and later Clang don't, and I don't think the advantage in warnings exists against newer GCCs.

probably it's time to use a newer Clang, like Clang-18?

I would really like to use C++ ranges in our code. And - if using libstd++ - 'ranges' should not be used with Clang < 16.
See for example NVIDIA/stdexec#1003.
I now have a valid PR that does not pass CI because of that bug in the old Clang used.

All in all - I really hope we keep Clang in the CI (as otherwise Ceph will 'drift' from being compilable by it). But we should upgrade it now.

cbodley · 2024-07-04T20:29:49Z

probably it's time to use a newer Clang, like Clang-18?

for reference, this mostly just means the jenkins builders need a newer clang installed. for 'make check', src/script/lib-build.sh will use the newest version it finds (though that only checks up to 17)

these checks run on ubuntu jammy, and i see that jammy only has clang versions up to clang-15

it's probably time to start adding support for ubuntu 24.04 in the lab (jenkins builders, teuthology workers, etc). that goes up to clang-18

cbodley · 2024-07-04T21:22:20Z

p.s. these clang builds still use libstdc++, so our gcc version matters a lot too when it comes to library features like ranges

ronen-fr · 2024-07-05T12:35:21Z

these checks run on ubuntu jammy, and i see that jammy only has clang versions up to clang-15

there seem to be Clang 16 packages available for Jammy. Can we use the scripts that run as part of the CI process to install packages (i.e. - without having to recreate the images?)?

tchaikov · 2024-07-05T12:42:00Z

@ronen-fr we also need to find a ppa for jammy for installing newer libstdc++. probably https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test ?

require gcc >= 12 and rely on gcc-toolset-12 by default to provide it Signed-off-by: Casey Bodley <cbodley@redhat.com>

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cbodley · 2024-07-29T17:24:55Z

CMake Error at /usr/share/cmake-3.22/Modules/CMakeTestCXXCompiler.cmake:62 (message):
...
/usr/bin/ld: cannot find -lstdc++: No such file or directory

this branch seems to have broken the clang 'make check' (for all pull requests, not just this one). i opened https://tracker.ceph.com/issues/67233 to track this

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cbodley · 2024-07-30T19:44:36Z

@petrutlucian94 could i ask your help getting windows tests to use gcc-12? i have the script installing g++-12 but it's not found by cmake (although gcc-12 is)

-- The CXX compiler identification is unknown
-- The C compiler identification is GNU 12.3.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/gcc-12
CMake Error at CMakeLists.txt:3 (project):
  The CMAKE_CXX_COMPILER:

    g++-12

  is not a full path and was not found in the PATH.

tchaikov · 2024-07-30T22:42:18Z

win32_deps_build.sh

        sudo apt-get update
        sudo env DEBIAN_FRONTEND=noninteractive apt-get -y install \
-            mingw-w64 g++ cmake pkg-config \
+            mingw-w64 g++-12 cmake pkg-config \


probably should install g++-mingw-w64 instead ? but i think we need to upgrade the jenkins work node to ubuntu/noble first for accessing g++ >= 12. as ubuntu/noble is the first stable release which provides the mingw tool chain with g++ >= 12. see https://packages.ubuntu.com/search?suite=default&section=all&arch=any&keywords=g%2B%2B-mingw-w64&searchon=names

Hi, we're building the Windows binaries using mingw-llvm:

https://github.com/ceph/ceph/blob/81a258352afcf376d4237dcd9dab6bb54d5fd6cc/win32_deps_build.sh#L43C15-L44

ceph/mingw_conf.sh

Lines 36 to 53 in 81a2583

if [[ -n $USE_MINGW_LLVM ]]; then

# This package isn't currently provided by Linux distributions, we're

# fetching it from Github.

export PATH="$MINGW_LLVM_DIR/bin:$PATH"

mingwPosix=""

mingwVersion="$(${MINGW_CPP}${mingwPosix} -dumpversion)"

mingwX64IncludeDir="$MINGW_LLVM_DIR/x86_64-w64-mingw32/include"

mingwX64BinDir="$MINGW_LLVM_DIR/x86_64-w64-mingw32/bin"

mingwX64LibDir="$MINGW_LLVM_DIR/x86_64-w64-mingw32/lib"

mingwTargetLibDir="$mingwX64BinDir"

mingwLibpthreadDir="$mingwX64BinDir"

PTW32Include="$mingwX64IncludeDir"

PTW32Lib="$mingwX64LibDir"

MINGW_CC="${MINGW_BASE}-clang${mingwPosix}"

MINGW_CXX="${MINGW_BASE}-clang++${mingwPosix}"

MINGW_FIND_ROOT_PATH="$MINGW_LLVM_DIR/x86_64-w64-mingw32"

We're using just a few tools from the mingw-w64 package, including dlltool if I remember correctly.

For what is worth, we had lots of problems with mingw-gcc, expecially around winpthreads, which is why we had to switch to mingw-llvm: 3ce1e4a

About the Windows CI job: it builds both Windows and Linux binaries and it seems that the Windows build actually passes:

https://jenkins.ceph.com/job/ceph-windows-pull-requests/44528/consoleFull

WIN32 files zipped to: /home/ubuntu/ceph.zip real 42m33.561s user 0m0.305s sys 0m0.476s

It's the Linux build that fails: https://github.com/ceph/ceph-build/blob/e8d18c7aef15fa0424d096ba73a6e0d701a5215a/scripts/ceph-windows/setup_ceph_vstart#L31-L41

Since everything is running in a VM, I think all we have to do is to switch the Ubuntu image to 24.04: https://github.com/ceph/ceph-build/blob/e8d18c7aef15fa0424d096ba73a6e0d701a5215a/scripts/ceph-windows/setup_libvirt_ubuntu_vm#L12

github-actions · 2024-07-31T16:53:34Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

cbodley · 2024-07-31T17:11:18Z

closing this for now so it stops breaking 'make check' on other prs

github-actions bot added the build/ops label Jul 1, 2024

tchaikov reviewed Jul 1, 2024

View reviewed changes

cbodley force-pushed the wip-gcc-12 branch from 7d105c1 to 00a9717 Compare July 26, 2024 17:03

cbodley added 3 commits July 26, 2024 17:21

rpm: default to gcc-12

dd2b4e2

require gcc >= 12 and rely on gcc-toolset-12 by default to provide it Signed-off-by: Casey Bodley <cbodley@redhat.com>

deb: require g++-12 or above

7148366

Signed-off-by: Casey Bodley <cbodley@redhat.com>

install-deps: install gcc-12 for supported distros

ffc5265

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cbodley force-pushed the wip-gcc-12 branch from 3d63ca3 to ffc5265 Compare July 26, 2024 21:27

cbodley added 3 commits July 29, 2024 13:47

win32_deps_build.sh: install g++-12 for ubuntu

9a69f81

Signed-off-by: Casey Bodley <cbodley@redhat.com>

squash! rpm: default to gcc-12

0a41c42

DNM: deb: temporarily install libstdc++-12-dev

f568e67

tchaikov reviewed Jul 30, 2024

View reviewed changes

cbodley mentioned this pull request Jul 31, 2024

fmt: bump up version to 11.0.2 #58960

Closed

14 tasks

github-actions bot added the needs-rebase label Jul 31, 2024

cbodley closed this Jul 31, 2024

	if [[ -n $USE_MINGW_LLVM ]]; then
	# This package isn't currently provided by Linux distributions, we're
	# fetching it from Github.
	export PATH="$MINGW_LLVM_DIR/bin:$PATH"
	mingwPosix=""
	mingwVersion="$(${MINGW_CPP}${mingwPosix} -dumpversion)"
	mingwX64IncludeDir="$MINGW_LLVM_DIR/x86_64-w64-mingw32/include"
	mingwX64BinDir="$MINGW_LLVM_DIR/x86_64-w64-mingw32/bin"
	mingwX64LibDir="$MINGW_LLVM_DIR/x86_64-w64-mingw32/lib"
	mingwTargetLibDir="$mingwX64BinDir"
	mingwLibpthreadDir="$mingwX64BinDir"
	PTW32Include="$mingwX64IncludeDir"
	PTW32Lib="$mingwX64LibDir"

	MINGW_CC="${MINGW_BASE}-clang${mingwPosix}"
	MINGW_CXX="${MINGW_BASE}-clang++${mingwPosix}"

	MINGW_FIND_ROOT_PATH="$MINGW_LLVM_DIR/x86_64-w64-mingw32"

Conversation

cbodley commented Jul 1, 2024

Uh oh!

tchaikov Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tchaikov Jul 1, 2024

Choose a reason for hiding this comment

Uh oh!

cbodley Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

cbodley Jul 26, 2024

Choose a reason for hiding this comment

Uh oh!

cbodley Jul 26, 2024

Choose a reason for hiding this comment

Uh oh!

adamemerson commented Jul 2, 2024

Uh oh!

adamemerson commented Jul 2, 2024

Uh oh!

cbodley commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamemerson commented Jul 2, 2024

Uh oh!

tchaikov commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronen-fr commented Jul 4, 2024

Uh oh!

cbodley commented Jul 4, 2024

Uh oh!

cbodley commented Jul 4, 2024

Uh oh!

ronen-fr commented Jul 5, 2024

Uh oh!

tchaikov commented Jul 5, 2024

Uh oh!

cbodley commented Jul 29, 2024

Uh oh!

cbodley commented Jul 30, 2024

Uh oh!

tchaikov Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petrutlucian94 Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

petrutlucian94 Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

petrutlucian94 Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 31, 2024

Uh oh!

cbodley commented Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tchaikov Jul 1, 2024 •

edited

Loading

cbodley commented Jul 2, 2024 •

edited

Loading

tchaikov commented Jul 2, 2024 •

edited

Loading

tchaikov Jul 30, 2024 •

edited

Loading