Skip to content

squid: common: fix string creation from '0' in LogEntry#58934

Closed
cbodley wants to merge 1 commit intoceph:squidfrom
cbodley:wip-67272-squid
Closed

squid: common: fix string creation from '0' in LogEntry#58934
cbodley wants to merge 1 commit intoceph:squidfrom
cbodley:wip-67272-squid

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Jul 30, 2024

backport tracker: https://tracker.ceph.com/issues/67272

backport of #55905
parent tracker: https://tracker.ceph.com/issues/67271

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@ronen-fr @cbodley
common: fix string creation from '0' in LogEntry
23aefc0 
C++23 disallows conversion from 'int' to 'string'.
That includes returning '0' from a function that returns a string.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit b854bfc)
@cbodley cbodley added this to the squid milestone Jul 30, 2024
@cbodley cbodley added the common label Jul 30, 2024
@cbodley cbodley mentioned this pull request Jul 30, 2024
Merged
@cbodley cbodley requested a review from ronen-fr July 30, 2024 18:16
@cbodley
Copy link
Contributor Author

cbodley commented Jul 30, 2024

https://jenkins.ceph.com/job/ceph-pull-requests/140279/

The following tests FAILED:
240 - unittest-seastar-buffer (Failed)
242 - unittest-seastar-socket (Failed)
243 - unittest-seastar-messenger (Failed)
244 - unittest-seastar-alienstore-thread-pool (Failed)
245 - unittest-seastar-config (Failed)
246 - unittest-seastar-perfcounters (Failed)
250 - unittest-interruptible-future (Failed)
251 - unittest-seastar-messenger-thrash (Failed)
252 - unittest-seastar-errorator (Failed)
253 - unittest-crimson-coroutine (Failed)
254 - unittest-transaction-manager (Failed)
255 - unittest-btree-lba-manager (Failed)
256 - unittest-seastore-journal (Failed)
257 - unittest-seastore-cache (Failed)
258 - unittest-object-data-handler (Failed)
259 - unittest-collection-manager (Failed)
260 - unittest-omap-manager (Failed)
261 - unittest-seastore (Failed)
262 - unittest-seastore-randomblock-manager (Failed)
263 - unittest-seastore-nvmedevice (Failed)
264 - unittest-seastore-cbjournal (Failed)
265 - unittest-seastore-extent-allocator (Failed)
266 - unittest-staged-fltree (Failed)
267 - unittest-fltree-onode-manager (Failed)

@cbodley
Copy link
Contributor Author

cbodley commented Jul 30, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Jul 30, 2024

The following tests FAILED:
22 - run-tox-cephadm (Failed)
254 - unittest-transaction-manager (Failed)
255 - unittest-btree-lba-manager (Failed)
257 - unittest-seastore-cache (Failed)
258 - unittest-object-data-handler (Failed)
259 - unittest-collection-manager (Failed)
260 - unittest-omap-manager (Failed)
262 - unittest-seastore-randomblock-manager (Failed)
263 - unittest-seastore-nvmedevice (Failed)
264 - unittest-seastore-cbjournal (Failed)
266 - unittest-staged-fltree (Failed)
267 - unittest-fltree-onode-manager (Failed)

looks like https://tracker.ceph.com/issues/66887

@cbodley
Copy link
Contributor Author

cbodley commented Jul 30, 2024

jenkins test make check

@Matan-B
Copy link
Contributor

Matan-B commented Jul 31, 2024

jenkins test make check

@Matan-B
Copy link
Contributor

Matan-B commented Jul 31, 2024 •
edited
Loading

#58890

This one passed make check but has no tracker, so I'll await for yours to pass CI.

@Matan-B
Copy link
Contributor

Matan-B commented Jul 31, 2024

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Jul 31, 2024

#58890

This one passed make check but has no tracker, so I'll await for yours to pass CI.

this pr's make check is still blocked on https://tracker.ceph.com/issues/66887, let's merge that one instead

@cbodley cbodley closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzarzynski rzarzynski rzarzynski approved these changes

@ronen-fr ronen-fr ronen-fr approved these changes

@tchaikov tchaikov Awaiting requested review from tchaikov

@Matan-B Matan-B Awaiting requested review from Matan-B

Assignees

No one assigned

Labels

common

Projects

None yet

Milestone

squid

Development

Successfully merging this pull request may close these issues.

4 participants

@cbodley @Matan-B @rzarzynski @ronen-fr