Ceph » crimson

Hi @Matan Breizman @Yingxin Cheng Could you have a look?

Looks like fmt issue:

  FMT_CONSTEXPR void check_dynamic_spec(int arg_id) {
    if (arg_id < num_args_ && types_ && !is_integral_type(types_[arg_id]))
      this->on_error("width/precision is not integer");
  }

Yes, it is fmt related.
Seems like some servers like omani001, not sure why, but the server's clang links libgcc12 (others link libgcc11), cause a check:
template <typename Char, typename ErrorHandler>

FMT_CONSTEXPR void
basic_format_parse_context<Char, ErrorHandler>::check_dynamic_spec(int arg_id) {
  if (detail::is_constant_evaluated()) {
    using context = detail::compile_parse_context<Char, ErrorHandler>;
    static_cast<context*>(this)->check_dynamic_spec(arg_id);
  }
}

After I degraded to libgcc11, the issue disappeared. But I need more time to figure it out.

@Matan Breizman @Kefu Chai Seem like same as https://github.com/llvm/llvm-project/issues/55638

I prefer to upgrade FMT version because it add 'gcc version check'. Any opinion?

Rongqi Sun wrote in #note-4:

@Matan Breizman @Kefu Chai Seem like same as https://github.com/llvm/llvm-project/issues/55638

I prefer to upgrade FMT version because it add 'gcc version check'. Any opinion?

Are you suggesting that upgrading fmt version will help us to avoid this issue?
Note, fmt is included as a submodule in Ceph.

Are you suggesting that upgrading fmt version will help us to avoid this issue?

Yes

Note, fmt is included as a submodule in Ceph.

So I ask for comments before PR, not sure what side affects will arise.