crimson: access coll_map under alien tp with a lock#58766
Merged
Conversation
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Fixes: https://tracker.ceph.com/issues/66294 Signed-off-by: Samuel Just <sjust@redhat.com>
Contributor
Author
|
10 job rados/thrash run, no failures: https://pulpito.ceph.com/sjust-2024-07-23_08:42:01-crimson-rados:thrash-wip-sjust-crimson-testing-2024-07-22-distro-default-smithi/ |
cyx1231st
approved these changes
Jul 24, 2024
Member
cyx1231st
left a comment
There was a problem hiding this comment.
Moving coll_map out of seastar and to be protected by coll_map_lock looks reasonable.
Matan-B
approved these changes
Jul 24, 2024
Contributor
|
https://pulpito.ceph.com/matan-2024-07-24_07:30:51-crimson-rados-wip-sjust-crimson-testing-2024-07-22-distro-crimson-smithi/ |
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
…on-race crimson: access coll_map under alien tp with a lock Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com> Reviewed-by: Matan Breizman <mbreizma@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e