squid: mds: set the proper extra bl for the create request#58527
Merged
lxbsz merged 4 commits intoceph:squidfrom Jul 22, 2024
Merged
squid: mds: set the proper extra bl for the create request#58527lxbsz merged 4 commits intoceph:squidfrom
lxbsz merged 4 commits intoceph:squidfrom
Conversation
Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit d48b169)
Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit 6615a56)
In the client side it will decode the extra info depending on the feature bits, but if we always encode it with the old version then the client could crash or gets the corrupted data. More detail please see "parse_reply_info_create()" in kclient code. Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit 1f1198b)
Just in case a create request was totally completed but the client didn't receive any unsafe and safe responses, and then when it's retried in the MDS side it will be treated as a open request and will miss setting the create ino for the reply message. Finally for client it just sent a create request and then the MDS just sent back a open reply, which will let the client miss setting the CREATED flag and then the VFS will fail the create by returnning a -EEXIST errno. Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com> (cherry picked from commit 3482100)
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/66906. |
lxbsz
approved these changes
Jul 22, 2024
Member
lxbsz
left a comment
There was a problem hiding this comment.
None of the failure is related to this backport PR:
More detail please see section 2024-07-17 in https://tracker.ceph.com/projects/cephfs/wiki/Squid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/66626
backport of #57754
parent tracker: https://tracker.ceph.com/issues/63265
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh