mds: set the proper extra bl for the create request#57754
Merged
Conversation
Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com>
In the client side it will decode the extra info depending on the feature bits, but if we always encode it with the old version then the client could crash or gets the corrupted data. More detail please see "parse_reply_info_create()" in kclient code. Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Just in case a create request was totally completed but the client didn't receive any unsafe and safe responses, and then when it's retried in the MDS side it will be treated as a open request and will miss setting the create ino for the reply message. Finally for client it just sent a create request and then the MDS just sent back a open reply, which will let the client miss setting the CREATED flag and then the VFS will fail the create by returnning a -EEXIST errno. Fixes: https://tracker.ceph.com/issues/63265 Signed-off-by: Xiubo Li <xiubli@redhat.com>
batrick
approved these changes
Jun 5, 2024
Member
|
jenkins test make check arm64 |
Member
|
This PR is under test in https://tracker.ceph.com/issues/66433. |
Member
|
This PR is under test in https://tracker.ceph.com/issues/66462. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 13, 2024
* refs/pull/57754/head: mds: set the proper extra bl for the create request mds: encode the correct extra info depending on the feature bits mds: add set_reply_extra_bl() helper support mds: cleanup the code to make it to be more readable
Member
|
This PR is under test in https://tracker.ceph.com/issues/66609. |
Member
This was referenced Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just in case a create request was totally completed but the client
didn't receive any unsafe and safe responses, and then when it's
retried in the MDS side it will be treated as a open request and
will miss setting the create ino for the reply message.
Finally for client it just sent a create request and then the MDS
just sent back a open reply, which will let the client miss setting
the CREATED flag and then the VFS will fail the create by returnning
a -EEXIST errno.
Fixes: https://tracker.ceph.com/issues/63265
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e