crimson: audit and correct epoch captured by IOInterruptCondition#58463
Merged
crimson: audit and correct epoch captured by IOInterruptCondition#58463
Conversation
This allows a with_interruption caller to specify an epoch other than the current pg epoch. Doing so is important if the operation in question was initiated prior to continuation which invokes with_interruption and a map advance may have occured in the mean time. Signed-off-by: Samuel Just <sjust@redhat.com>
…for interruption Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Contributor
Author
|
crimson-rados/thrash --limit 10 sjust-2024-07-06_06:23:37-crimson-rados:thrash-wip-sjust-crimson-testing-2024-07-05-distro-default-smithi: one notable failure, looks good otherwise
Full crimson-rados run pending https://pulpito.ceph.com/sjust-2024-07-07_00:37:55-crimson-rados-wip-sjust-crimson-testing-2024-07-05-distro-default-smithi/ |
Contributor
Author
|
jenkins test make check |
Contributor
Author
Matan-B
approved these changes
Jul 9, 2024
Contributor
|
jenkins test api |
Contributor
Contributor
Author
|
Bug in InternalClientRequest, @Matan-B good catch! moved pg before pg->get_osdmap_epoch(). |
… use for interruption Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
…epoch Let's be explicit about this as allowing the epoch to be grabbed out of pg->get_osdmap_epoch() implicitely is going to be wrong fairly often. Signed-off-by: Samuel Just <sjust@redhat.com>
…ion(Ref<PG>& pg); constructor This variant is error prone, better to be explicit. Signed-off-by: Samuel Just <sjust@redhat.com>
…ents Signed-off-by: Samuel Just <sjust@redhat.com>
d990592 to
b49f82a
Compare
Contributor
Author
|
Repushed with fix. |
Matan-B
approved these changes
Jul 21, 2024
Contributor
|
jenkins test make check |
Contributor
|
jenkins test api |
1 similar comment
Contributor
|
jenkins test api |
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Aug 1, 2024
…t-epoch crimson: audit and correct epoch captured by IOInterruptCondition Reviewed-by: Matan Breizman <mbreizma@redhat.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e