reef: client: do not proceed with I/O if filehandle is invalid#58397
Merged
reef: client: do not proceed with I/O if filehandle is invalid#58397
Conversation
Member
|
jenkins test make check |
joscollin
reviewed
Jul 10, 2024
Member
joscollin
left a comment
There was a problem hiding this comment.
@dparmar18 The make check fails again.
Member
|
jenkins test make check |
Member
|
@dparmar18 Could you rebase this PR to the latest ? The make check failure couldn't be fixed by retrying it. Thanks. |
Contributor
Author
|
5fd5f68 to
cfae287
Compare
Contributor
Author
|
@lxbsz rebased |
Contributor
|
@dparmar18 Please include fixes from #59300 in this backport. |
and test that providing null or invalid file handle returns an error as expected Fixes: https://tracker.ceph.com/issues/66156 Signed-off-by: Dhairya Parmar <dparmar@redhat.com> (cherry picked from commit bc4bb1e)
It is named _ll_fh_exists meaning it is a helper func only to be used with low level APIs. Fixes: https://tracker.ceph.com/issues/64313 Signed-off-by: Dhairya Parmar <dparmar@redhat.com> (cherry picked from commit 5d1255c)
and guard the `if (!mref_reader.is_state_satisfied())` stmt with braces. Fixes: https://tracker.ceph.com/issues/64313 Signed-off-by: Dhairya Parmar <dparmar@redhat.com> (cherry picked from commit 6614933)
Credit to Brad Hubbard for grabbing the stack trace. Fixes: https://tracker.ceph.com/issues/67565 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit c37ad2b)
cfae287 to
cfbc80a
Compare
Contributor
Author
Done. Just a note: since async i/o doesn't exist in reef, the snippet patching |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/67981. |
vshankar
approved these changes
Nov 9, 2024
Contributor
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57576 and some commits from #55457
Backport tracker: https://tracker.ceph.com/issues/64740
Parent tracker: https://tracker.ceph.com/issues/64313
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e