Skip to content

src/test: add testcase file for low level sync io code paths#57576

Merged
vshankar merged 1 commit intoceph:mainfrom
dparmar18:sync-codepath-testcase-invalid-fh
Jun 25, 2024
Merged

src/test: add testcase file for low level sync io code paths#57576
vshankar merged 1 commit intoceph:mainfrom
dparmar18:sync-codepath-testcase-invalid-fh

Conversation

@dparmar18
Copy link
Contributor

@dparmar18 dparmar18 commented May 20, 2024 •
edited
Loading

and test that providing null or invalid file handle returns an error as expected

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@dparmar18
Copy link
Contributor Author

dparmar18 commented May 20, 2024 •
edited
Loading

backports like https://tracker.ceph.com/issues/64740 or https://tracker.ceph.com/issues/64739 which are intended for async io are not possible because older releases do not have that feature(feature is available only since squid), but that doesn't mean we cannot/shouldn't backport the patch #55457, the code that it fixes also impact the sync code path, we anyways have a tracker for this https://tracker.ceph.com/issues/63712 to add sync io (low level) code path test cases so let us have this test case merged into main and then this test case along with the source code from #55457 can be backported for the backport trackers mentioned above.

@dparmar18 dparmar18 requested a review from a team May 20, 2024 19:11
@dparmar18 dparmar18 added the cephfs Ceph File System label May 20, 2024
@dparmar18
Copy link
Contributor Author

dparmar18 commented May 20, 2024

Passes locally

[       OK ] TestClient.LlreadvLlwritevInvalidFileHandleSync (207 ms)
[----------] 27 tests from TestClient (8600 ms total)

[----------] Global test environment tear-down
[==========] 27 tests from 1 test suite ran. (8600 ms total)
[  PASSED  ] 27 tests.

@dparmar18
Copy link
Contributor Author

dparmar18 commented May 20, 2024

backports like https://tracker.ceph.com/issues/64740 or https://tracker.ceph.com/issues/64739 which are intended for async io are not possible because older releases do not have that feature(feature is available only since squid), but that doesn't mean we cannot/shouldn't backport the patch #55457, the code that it fixes also impact the sync code path, we anyways have a tracker for this https://tracker.ceph.com/issues/63712 to add sync io (low level) code path test cases so let us have this test case merged into main and then this test case along with the source code from #55457 can be backported for the backport trackers mentioned above.

once i'm done with my ongoing work, i'll push more test cases to this file for better sync io code coverage

@dparmar18 dparmar18 force-pushed the sync-codepath-testcase-invalid-fh branch from 31d05d2 to 7b074f8 Compare May 21, 2024 09:44
@dparmar18
src/test: add testcase file for low level sync io code paths
bc4bb1e 
and test that providing null or invalid file handle returns an error as expected

Fixes: https://tracker.ceph.com/issues/66156
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
@dparmar18 dparmar18 force-pushed the sync-codepath-testcase-invalid-fh branch from 7b074f8 to bc4bb1e Compare May 21, 2024 09:46
@vshankar
Copy link
Contributor

vshankar commented May 23, 2024

@dparmar18 As discussed, this needs to be backported along with the async test cases. For releases that don't have the async calls, we can backport the sync test cases.

@vshankar
Copy link
Contributor

vshankar commented May 23, 2024

once i'm done with my ongoing work, i'll push more test cases to this file for better sync io code coverage

Please tag me on the PR when its ready for review.

@dparmar18
Copy link
Contributor Author

dparmar18 commented May 23, 2024

once i'm done with my ongoing work, i'll push more test cases to this file for better sync io code coverage

Please tag me on the PR when its ready for review.

this is ready for review, for now this is the only sync io test case that needs to be merged

@vshankar
Copy link
Contributor

vshankar commented Jun 3, 2024

This PR is under test in https://tracker.ceph.com/issues/66327.

@vshankar
Copy link
Contributor

vshankar commented Jun 17, 2024

This PR is under test in https://tracker.ceph.com/issues/66522.

vshankar
vshankar approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20240617094253-debug

(https://tracker.ceph.com/issues/66522)

@vshankar vshankar merged commit 689bdac into ceph:main Jun 25, 2024
This was referenced Jul 2, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

No one assigned

Labels

build/ops cephfs Ceph File System tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dparmar18 @vshankar