Skip to content

qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname#58311

Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave:fs-auth-nonalpha-test
Jul 12, 2024
Merged

qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname#58311
rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave:fs-auth-nonalpha-test

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Jun 27, 2024

This test deletes the CephFS already present on the cluster at the very
beginning and unmounts the first client beforehand. But it leaves the
second client mounted on this deleted CephFS that doesn't exist for the
rest of the test. And then at the very end of this test it attempts to
remount the second client (during tearDown()) which hangs and causes
test runner to crash.

Unmount the second client beforehand to prevent the bug and delete
mount_b object to avoid confusion for the readers in future about
whether or not 2nd mountpoint exists.

Fixes: https://tracker.ceph.com/issues/66077

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rishabh-d-dave rishabh-d-dave requested a review from a team June 27, 2024 12:41
dparmar18
dparmar18 previously approved these changes Jun 27, 2024
@rishabh-d-dave rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Jul 1, 2024
@rishabh-d-dave rishabh-d-dave force-pushed the fs-auth-nonalpha-test branch from 41e3523 to 04cea6a Compare July 1, 2024 07:26
@rishabh-d-dave rishabh-d-dave force-pushed the fs-auth-nonalpha-test branch from 04cea6a to 45f4c7a Compare July 1, 2024 13:12
@rishabh-d-dave rishabh-d-dave requested review from lxbsz and vshankar July 1, 2024 13:16
@rishabh-d-dave rishabh-d-dave removed the wip-rishabh-testing Rishabh's testing label label Jul 1, 2024
@dparmar18 dparmar18 self-requested a review July 1, 2024 13:19
@dparmar18 dparmar18 dismissed their stale review July 1, 2024 13:19

changes made post approval

@rishabh-d-dave rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label Jul 1, 2024
Copy link
Contributor Author

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#11-JUL-2024

Testing took some time because first there were issues with building testing branch, then there were too many infra failures, then there were failures due to one of the PRs in the testing branch and finally last run's rerun had new failures that need to be checked.

There were no failures related to this PR, so QA was successful.

@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

jenkins test make check

rishabh-d-dave added a commit to rishabh-d-dave/ceph that referenced this pull request Jul 11, 2024
* refs/pull/58311/head:
	qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname

Reviewed-by: Venky Shankar <vshankar@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

@rishabh-d-dave
Copy link
Contributor Author

jenkins test make check

This test deletes the CephFS already present on the cluster at the very
beginning and unmounts the first client beforehand. But it leaves the
second client mounted on this deleted CephFS that doesn't exist for the
rest of the test. And then at the very end of this test it attempts to
remount the second client (during tearDown()) which hangs and causes
test runner to crash.

Unmount the second client beforehand to prevent the bug and delete
mount_b object to avoid confusion for the readers in future about
whether or not 2nd mountpoint exists.

Fixes: https://tracker.ceph.com/issues/66077
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave force-pushed the fs-auth-nonalpha-test branch from 45f4c7a to 2130ec8 Compare July 11, 2024 16:38
@rishabh-d-dave
Copy link
Contributor Author

Rebased PR branch to avoid repetitive unrelated make check and ceph api failures on CI.

@rishabh-d-dave
Copy link
Contributor Author

once again, unrelated "ceph api" failure - https://jenkins.ceph.com/job/ceph-api/77615/

@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

API failed with a new error once again - https://jenkins.ceph.com/job/ceph-api/77626/. PR #58101 also had same issue but eventually ceph API passed, so I'll re-try.

@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Jul 12, 2024

Link to comment where QA results were reported - #58311 (review)

@rishabh-d-dave rishabh-d-dave merged commit 3f4aee2 into ceph:main Jul 12, 2024
@rishabh-d-dave rishabh-d-dave deleted the fs-auth-nonalpha-test branch July 12, 2024 10:55
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System needs-review tests wip-rishabh-testing Rishabh's testing label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants