Skip to content

reef: qa: fixing tests in test_cephfs_shell.TestShellOpts#58111

Merged
vshankar merged 2 commits intoceph:reeffrom
neesingh-rh:wip-65348-reef
Nov 9, 2024
Merged

reef: qa: fixing tests in test_cephfs_shell.TestShellOpts#58111
vshankar merged 2 commits intoceph:reeffrom
neesingh-rh:wip-65348-reef

Conversation

@neesingh-rh
Copy link
Contributor

@neesingh-rh neesingh-rh commented Jun 18, 2024 •
edited
Loading

backport tracker: https://tracker.ceph.com/issues/65348

backport of #55725
parent tracker: https://tracker.ceph.com/issues/63699

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

neeraj pratap singh added 2 commits June 18, 2024 14:01
cephfs-shell: fixing TestShellOpts in test_cephfs_shell.py
a96e375 
The issue arose due to the change in the output format of the
command `set editor`. Earlier the output format was like:
`editor: 'vim' ` which has been changed to:
```Name    Value                           Description
====================================================================================================
editor  vim                             Program used by 'edit' ```

Due to which fetching the list using indexes was `out of range`.

Introduced by: python-cmd2/cmd2@fd38e70
Fixes: https://tracker.ceph.com/issues/63699
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 118ac67)
qa: correcting the output in the comments as per new structure
3306d78 
Introduced by: python-cmd2/cmd2@fd38e70
Fixes: https://tracker.ceph.com/issues/63699
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 198d177)
@github-actions github-actions bot added cephfs Ceph File System tests labels Jun 18, 2024
@github-actions github-actions bot added this to the reef milestone Jun 18, 2024
@joscollin joscollin added the wip-jcollin-testing-reef1 Assigned for review label Jun 25, 2024
@joscollin
Copy link
Member

joscollin commented Jun 25, 2024

This PR is under test in https://tracker.ceph.com/issues/66685.

@lxbsz
Copy link
Member

lxbsz commented Jul 4, 2024

@neesingh-rh I am afraid this PR caused this qa test failure , could you help confirm that ?

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Jul 4, 2024

@neesingh-rh I am afraid this PR caused this qa test failure , could you help confirm that ?

Will check

@joscollin joscollin requested a review from a team July 10, 2024 11:42
@joscollin joscollin removed the wip-jcollin-testing-reef1 Assigned for review label Jul 13, 2024
@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Jul 15, 2024 •
edited
Loading

@neesingh-rh I am afraid this PR caused this qa test failure , could you help confirm that ?

I did check the log you mentioned above and seeing the output structure of set editor command it looks like we don't need this change for reef.
Earlier, we decided that this shouldn't go for reef as it exists only for centos9 https://tracker.ceph.com/issues/65348#note-2 but after this https://tracker.ceph.com/issues/65348#note-4 I created this PR.
@joscollin Can u pls re-look to this run https://pulpito.ceph.com/leonidus-2024-06-16_14:17:14-fs-wip-leonidus-testing-20240616.070940-reef-distro-default-smithi/7758404 , what caused this failure.

@lxbsz
Copy link
Member

lxbsz commented Jul 16, 2024

@neesingh-rh I am afraid this PR caused this qa test failure , could you help confirm that ?

I did check the log you mentioned above and seeing the output structure of set editor command it looks like we don't need this change for reef. Earlier, we decided that this shouldn't go for reef as it exists only for centos9 https://tracker.ceph.com/issues/65348#note-2 but after this https://tracker.ceph.com/issues/65348#note-4 I created this PR. @joscollin Can u pls re-look to this run https://pulpito.ceph.com/leonidus-2024-06-16_14:17:14-fs-wip-leonidus-testing-20240616.070940-reef-distro-default-smithi/7758404 , what caused this failure.

In reef we hit this too, please see https://pulpito.ceph.com/jcollin-2024-07-02_01:59:44-fs-wip-jcollin-testing-20240701.083303-reef-distro-default-smithi/7783233

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Jul 16, 2024

@neesingh-rh I am afraid this PR caused this qa test failure , could you help confirm that ?

I did check the log you mentioned above and seeing the output structure of set editor command it looks like we don't need this change for reef. Earlier, we decided that this shouldn't go for reef as it exists only for centos9 https://tracker.ceph.com/issues/65348#note-2 but after this https://tracker.ceph.com/issues/65348#note-4 I created this PR. @joscollin Can u pls re-look to this run https://pulpito.ceph.com/leonidus-2024-06-16_14:17:14-fs-wip-leonidus-testing-20240616.070940-reef-distro-default-smithi/7758404 , what caused this failure.

In reef we hit this too, please see https://pulpito.ceph.com/jcollin-2024-07-02_01:59:44-fs-wip-jcollin-testing-20240701.083303-reef-distro-default-smithi/7783233

I don't understand why the output structure of set editor is different in two reef runs:
https://pulpito.ceph.com/jcollin-2024-07-02_01:59:44-fs-wip-jcollin-testing-20240701.083303-reef-distro-default-smithi/7783233 :

2024-07-04T16:39:36.362 DEBUG:teuthology.orchestra.run.smithi016:> cephfs-shell -c /tmp/tmp.fqwx8qBsX3 -- 'set editor ?, set editor'
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:editor - was: 'vim'
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:now: '?'
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:Name    Value                           Description
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:====================================================================================================
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:editor  ?                               Program used by 'edit'

and http://qa-proxy.ceph.com/teuthology/jcollin-2024-06-26_02:20:03-fs-wip-jcollin-testing-20240625.103903-reef-distro-default-smithi/7772681/teuthology.log:

2024-06-29T03:27:59.478 DEBUG:teuthology.orchestra.run.smithi001:> cephfs-shell -c /tmp/tmp.DKVBZHNKyb -- 'set editor ?, set editor'
2024-06-29T03:27:59.674 INFO:teuthology.orchestra.run.smithi001.stdout:editor - was: vim
2024-06-29T03:27:59.674 INFO:teuthology.orchestra.run.smithi001.stdout:now: ?
2024-06-29T03:27:59.674 INFO:teuthology.orchestra.run.smithi001.stdout:editor: ?

@vshankar
Copy link
Contributor

vshankar commented Aug 2, 2024

Had a conversation with @neesingh-rh regarding this - please check if the upgraded cmd2 module is a part of reef branch and available in the distro's we support.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Aug 5, 2024

@neesingh-rh I am afraid this PR caused this qa test failure , could you help confirm that ?

I did check the log you mentioned above and seeing the output structure of set editor command it looks like we don't need this change for reef. Earlier, we decided that this shouldn't go for reef as it exists only for centos9 https://tracker.ceph.com/issues/65348#note-2 but after this https://tracker.ceph.com/issues/65348#note-4 I created this PR. @joscollin Can u pls re-look to this run https://pulpito.ceph.com/leonidus-2024-06-16_14:17:14-fs-wip-leonidus-testing-20240616.070940-reef-distro-default-smithi/7758404 , what caused this failure.

In reef we hit this too, please see https://pulpito.ceph.com/jcollin-2024-07-02_01:59:44-fs-wip-jcollin-testing-20240701.083303-reef-distro-default-smithi/7783233

I don't understand why the output structure of set editor is different in two reef runs: https://pulpito.ceph.com/jcollin-2024-07-02_01:59:44-fs-wip-jcollin-testing-20240701.083303-reef-distro-default-smithi/7783233 :

2024-07-04T16:39:36.362 DEBUG:teuthology.orchestra.run.smithi016:> cephfs-shell -c /tmp/tmp.fqwx8qBsX3 -- 'set editor ?, set editor'
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:editor - was: 'vim'
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:now: '?'
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:Name    Value                           Description
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:====================================================================================================
2024-07-04T16:39:36.652 INFO:teuthology.orchestra.run.smithi016.stdout:editor  ?                               Program used by 'edit'

and http://qa-proxy.ceph.com/teuthology/jcollin-2024-06-26_02:20:03-fs-wip-jcollin-testing-20240625.103903-reef-distro-default-smithi/7772681/teuthology.log:

2024-06-29T03:27:59.478 DEBUG:teuthology.orchestra.run.smithi001:> cephfs-shell -c /tmp/tmp.DKVBZHNKyb -- 'set editor ?, set editor'
2024-06-29T03:27:59.674 INFO:teuthology.orchestra.run.smithi001.stdout:editor - was: vim
2024-06-29T03:27:59.674 INFO:teuthology.orchestra.run.smithi001.stdout:now: ?
2024-06-29T03:27:59.674 INFO:teuthology.orchestra.run.smithi001.stdout:editor: ?

This issue exists only in centos 9, but here http://qa-proxy.ceph.com/teuthology/jcollin-2024-06-26_02:20:03-fs-wip-jcollin-testing-20240625.103903-reef-distro-default-smithi/7772681/teuthology.log along with this patch we are testing it in ubuntu 20.04, that's why it is failing for it.

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Sep 10, 2024

This PR is under test in https://tracker.ceph.com/issues/67981.

vshankar
vshankar approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Reef#wip-rishabh-testing-20240910100730-reef

@vshankar vshankar merged commit e737a02 into ceph:reef Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System needs-qa tests wip-rishabh-testing9

Projects

None yet

Milestone

reef

Development

Successfully merging this pull request may close these issues.

5 participants

@neesingh-rh @joscollin @lxbsz @vshankar @rishabh-d-dave