Skip to content

qa: fixing tests in test_cephfs_shell.TestShellOpts#55725

Merged
vshankar merged 2 commits intoceph:mainfrom
neesingh-rh:wip-63699
Apr 5, 2024
Merged

qa: fixing tests in test_cephfs_shell.TestShellOpts#55725
vshankar merged 2 commits intoceph:mainfrom
neesingh-rh:wip-63699

Conversation

@neesingh-rh
Copy link
Contributor

@neesingh-rh neesingh-rh commented Feb 23, 2024 •
edited
Loading

Intoduced by: python-cmd2/cmd2@fd38e70
Fixes: https://tracker.ceph.com/issues/63699
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added cephfs Ceph File System tests labels Feb 23, 2024
@neesingh-rh neesingh-rh marked this pull request as draft February 23, 2024 03:59
@neesingh-rh neesingh-rh force-pushed the wip-63699 branch 3 times, most recently from e8e4ef3 to 3ed39de Compare February 23, 2024 08:44
@neesingh-rh neesingh-rh changed the title qa: testing fix for cephfs-shell qa: fixing tests in test_cephfs_shell.TestShellOpts Feb 23, 2024
@neesingh-rh neesingh-rh force-pushed the wip-63699 branch 4 times, most recently from 256e281 to 6101744 Compare February 23, 2024 10:45
@neesingh-rh neesingh-rh marked this pull request as ready for review February 23, 2024 10:45
@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Feb 23, 2024

Doesn't failing for test_cephfs_shell.TestShellOpts: https://pulpito.ceph.com/neesingh-2024-02-23_09:44:10-fs:shell-wip-neesingh-testing-220224-distro-default-smithi/

@neesingh-rh neesingh-rh marked this pull request as draft February 23, 2024 11:13
@neesingh-rh neesingh-rh force-pushed the wip-63699 branch 4 times, most recently from acc3ca1 to 6101744 Compare February 26, 2024 04:35
@neesingh-rh neesingh-rh marked this pull request as ready for review February 26, 2024 04:35
vshankar
vshankar requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neesingh-rh - the commit message needs to describe the issue and not just a line mentioning "fixing....."

@vshankar vshankar requested a review from a team February 26, 2024 06:07
@neesingh-rh neesingh-rh force-pushed the wip-63699 branch 2 times, most recently from e79b46f to 24abe18 Compare February 26, 2024 06:27
@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Feb 26, 2024

@neesingh-rh - the commit message needs to describe the issue and not just a line mentioning "fixing....."

Updated the commit with the description of the issue.

@vshankar
Copy link
Contributor

vshankar commented Feb 26, 2024

@neesingh-rh - the commit message needs to describe the issue and not just a line mentioning "fixing....."

Updated the commit with the description of the issue.

Thx. Additionally, please add a Introduced-by: <sha> tag in the commit message mentioning the commit which introduced the format change.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Feb 28, 2024

This came with the release 2.4 of cmd2, which can be read from the this documentation of set command : https://buildmedia.readthedocs.org/media/pdf/cmd2/latest/cmd2.pdf on page 26.

neeraj pratap singh added 2 commits February 28, 2024 14:37
cephfs-shell: fixing TestShellOpts in test_cephfs_shell.py
118ac67 
The issue arose due to the change in the output format of the
command `set editor`. Earlier the output format was like:
`editor: 'vim' ` which has been changed to:
```Name    Value                           Description
====================================================================================================
editor  vim                             Program used by 'edit' ```

Due to which fetching the list using indexes was `out of range`.

Introduced by: python-cmd2/cmd2@fd38e70
Fixes: https://tracker.ceph.com/issues/63699
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
qa: correcting the output in the comments as per new structure
198d177 
Introduced by: python-cmd2/cmd2@fd38e70
Fixes: https://tracker.ceph.com/issues/63699
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
@neesingh-rh neesingh-rh requested a review from vshankar February 28, 2024 09:09
@vshankar vshankar requested a review from joscollin February 29, 2024 11:04
@vshankar
Copy link
Contributor

vshankar commented Feb 29, 2024

jenkins retest this please

@vshankar
Copy link
Contributor

vshankar commented Mar 5, 2024

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented Mar 5, 2024

Will run this through tests. Thx @neesingh-rh

@vshankar
Copy link
Contributor

vshankar commented Mar 11, 2024

https://pulpito.ceph.com/?branch=wip-vshankar-testing-20240307.013758

(test run review pending)

@vshankar
Copy link
Contributor

vshankar commented Mar 14, 2024

@neesingh-rh I'm still seeing failures with this change in my test branch. See - https://pulpito.ceph.com/vshankar-2024-03-13_13:59:32-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7596692/.

PTAL. Dropping this from my test branch for now.

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Mar 14, 2024 •
edited
Loading

@neesingh-rh I'm still seeing failures with this change in my test branch. See - https://pulpito.ceph.com/vshankar-2024-03-13_13:59:32-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7596692/.

PTAL. Dropping this from my test branch for now.

@vshankar after checking the teuthology log, I found that the error it shows doesn't exist in new changes. and after I checked the test branch , it seems it doesn't contain the changes of this PR. Can u pls look again?
EDIT: https://github.com/ceph/ceph-ci/blob/wip-vshankar-testing-20240307.013758/qa/tasks/cephfs/test_cephfs_shell.py

@vshankar
Copy link
Contributor

vshankar commented Mar 14, 2024

@neesingh-rh I'm still seeing failures with this change in my test branch. See - https://pulpito.ceph.com/vshankar-2024-03-13_13:59:32-fs-wip-vshankar-testing-20240307.013758-testing-default-smithi/7596692/.
PTAL. Dropping this from my test branch for now.

@vshankar after checking the teuthology log, I found that the error it shows doesn't exist in new changes. and after I checked the test branch , it seems it doesn't contain the changes of this PR. Can u pls look again?

Wait.. what. Hang on...

@vshankar
Copy link
Contributor

vshankar commented Apr 2, 2024

Will put this to test today.

@vshankar
Copy link
Contributor

vshankar commented Apr 5, 2024

https://pulpito.ceph.com/vshankar-2024-04-04_12:53:12-fs:shell-wip-vshankar-testing-20240402.053423-testing-default-smithi/

@vshankar vshankar merged commit a21870a into ceph:main Apr 5, 2024
@vshankar
Copy link
Contributor

vshankar commented Apr 5, 2024

@neesingh-rh Does this need backport only for squid (I guess the issue happens only with centos9)?

@neesingh-rh
Copy link
Contributor Author

neesingh-rh commented Apr 5, 2024

@neesingh-rh Does this need backport only for squid (I guess the issue happens only with centos9)?

Yes, We are seeing this only with centos9

@neesingh-rh neesingh-rh mentioned this pull request Apr 16, 2024
Merged
@neesingh-rh neesingh-rh mentioned this pull request Jun 18, 2024
Merged
14 tasks
@neesingh-rh neesingh-rh mentioned this pull request Sep 30, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@joscollin joscollin Awaiting requested review from joscollin

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neesingh-rh @vshankar