Skip to content

client: eliminate duplicate lookups wherever possible#58097

Merged
vshankar merged 1 commit intoceph:mainfrom
gardran:wip-gardran-kill-count
Aug 7, 2024
Merged

client: eliminate duplicate lookups wherever possible#58097
vshankar merged 1 commit intoceph:mainfrom
gardran:wip-gardran-kill-count

Conversation

@gardran
Copy link
Contributor

@gardran gardran commented Jun 17, 2024

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Signed-off-by: Garry Drankovich <garry.drankovich@clyso.com>
@github-actions github-actions bot added the cephfs Ceph File System label Jun 17, 2024
@rishabh-d-dave rishabh-d-dave requested a review from a team July 2, 2024 16:58
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thx @gardran

@gardran
Copy link
Contributor Author

gardran commented Jul 24, 2024

@vshankar @mchangir - curious what happened with Milind's report comparing performance for optimized vs. non-optimized versions? It's not here any more :(

@vshankar
Copy link
Contributor

@vshankar @mchangir - curious what happened with Milind's report comparing performance for optimized vs. non-optimized versions? It's not here any more :(

Oh, I wasn't aware that @mchangir is running performance benchmarks with this change.

@mchangir
Copy link
Contributor

@vshankar @mchangir - curious what happened with Milind's report comparing performance for optimized vs. non-optimized versions? It's not here any more :(

I had miscalculated the timmings. Sorry about that.

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/67252.

vshankar added a commit to vshankar/ceph that referenced this pull request Jul 31, 2024
* refs/pull/58097/head:
	client: eliminate duplicate lokups wherever possible
vshankar added a commit to vshankar/ceph that referenced this pull request Jul 31, 2024
* refs/pull/58097/head:
	client: eliminate duplicate lokups wherever possible
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 7be9c53 into ceph:main Aug 7, 2024
@gardran gardran deleted the wip-gardran-kill-count branch August 7, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants