Skip to content

qa: suppress __trans_list_add valgrind warning#58056

Merged
batrick merged 2 commits intoceph:mainfrom
batrick:i65799
Jul 24, 2024
Merged

qa: suppress __trans_list_add valgrind warning#58056
batrick merged 2 commits intoceph:mainfrom
batrick:i65799

Conversation

@batrick
Copy link
Member

@batrick batrick commented Jun 15, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/65779

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@batrick batrick added cephfs Ceph File System needs-review labels Jun 15, 2024
@github-actions github-actions bot added the tests label Jun 15, 2024
@batrick batrick requested review from a team, mchangir and vshankar June 15, 2024 03:01
@batrick
Copy link
Member Author

batrick commented Jun 20, 2024

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Jun 22, 2024

This PR is under test in https://tracker.ceph.com/issues/66609.

@batrick
Copy link
Member Author

batrick commented Jul 3, 2024

This PR is under test in https://tracker.ceph.com/issues/66822.

@batrick batrick force-pushed the i65799 branch 2 times, most recently from 30c2983 to ee7cb13 Compare July 23, 2024 15:10
@batrick
qa: generate valgrind suppressions
cdef41d 
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
qa: suppress __trans_list_add valgrind warning
4d70741 
Fixes: https://tracker.ceph.com/issues/65779
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
Copy link
Member Author

batrick commented Jul 23, 2024

Tested this specifically after a few iterations on the correct suppression (I was missing an underscore /sigh).

https://pulpito.ceph.com/pdonnell-2024-07-23_17:58:55-fs:verify-main-distro-default-smithi/

It works:

<suppcounts>
  <pair>
    <count>21</count>
    <name>libstdc++ leak on xenial</name>
  </pair>
  <pair>
    <count>10</count>
    <name>tracker #65779: __trans_list_add annoyance</name>
  </pair>
  <pair>
    <count>2</count>
    <name>tcmalloc: string</name>
  </pair>
  <pair>
    <count>8</count>
    <name>something in glibc</name>
  </pair>
  <pair>
    <count>10997</count>
    <name>&lt;allthefrees, so we can behave with tcmalloc&gt;</name>
  </pair>
</suppcounts>

/teuthology/pdonnell-2024-07-23_17:58:55-fs:verify-main-distro-default-smithi/7814267/remote/smithi067/log/valgrind/mds.a.log.gz

@batrick
Copy link
Member Author

batrick commented Jul 23, 2024

@cbodley fyi suppressions are now included in the valgrind logs now.

@cbodley
Copy link
Contributor

cbodley commented Jul 23, 2024

@cbodley fyi suppressions are now included in the valgrind logs now.

very cool, cc @mkogan1

@batrick
Copy link
Member Author

batrick commented Jul 23, 2024

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Jul 24, 2024

jenkins test make check

@batrick batrick merged commit c8324ba into ceph:main Jul 24, 2024
@batrick batrick deleted the i65799 branch July 24, 2024 14:19
This was referenced Jul 24, 2024
Merged
Merged
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
@batrick @NitzanMordhai
Merge PR ceph#58056 into main
ca0fc82 
* refs/pull/58056/head:
	qa: suppress __trans_list_add valgrind warning
	qa: generate valgrind suppressions

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@mchangir mchangir Awaiting requested review from mchangir

Assignees

No one assigned

Labels

cephfs Ceph File System needs-review tests wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@batrick @cbodley @vshankar