Skip to content

qa/suites: drop --show-reachable=yes from fs:valgrind tests#57987

Merged
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-B64752-valgrind-report-leaks
Aug 7, 2024
Merged

qa/suites: drop --show-reachable=yes from fs:valgrind tests#57987
vshankar merged 1 commit intoceph:mainfrom
joscollin:wip-B64752-valgrind-report-leaks

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Jun 12, 2024 •
edited
Loading

Drop --show-reachable=yes from fs:valgrind tests as it shows CommandFailedError, which fails starting cephfs-mirror daemon and prevents the valgrind checks and reports. rbd:valgrind tests doesn't use --show-reachable=yes too.
So dropping --show-reachable=yes to make it analogous to rbd:valgrind.

Fixes: https://tracker.ceph.com/issues/64752
Fixes: https://tracker.ceph.com/issues/62221

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added cephfs Ceph File System tests labels Jun 12, 2024
@joscollin
qa/suites: drop --show-reachable=yes from fs:valgrind tests
f17f2d6 
Drop --show-reachable=yes from fs:valgrind tests as it shows CommandFailedError,
which fails starting cephfs-mirror daemon and prevents the valgrind checks and reports.
rbd:valgrind tests doesn't use --show-reachable=yes too.
So dropping --show-reachable=yes to make it analogous to rbd:valgrind.

Fixes: https://tracker.ceph.com/issues/64752
Fixes: https://tracker.ceph.com/issues/62221
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-B64752-valgrind-report-leaks branch from 66e9e33 to f17f2d6 Compare June 12, 2024 11:50
@joscollin
Copy link
Member Author

joscollin commented Jun 13, 2024

jenkins test make check

@vshankar vshankar requested a review from a team June 13, 2024 10:22
@joscollin
Copy link
Member Author

joscollin commented Jun 13, 2024

jenkins test make check arm64

chrisphoffman
chrisphoffman reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@chrisphoffman chrisphoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant on approving this removal. What is the general stance for ceph? I see a mix of use or not depending on where you look.

Were you able to find the root cause?

@joscollin
Copy link
Member Author

joscollin commented Jun 18, 2024

I'm hesitant on approving this removal. What is the general stance for ceph? I see a mix of use or not depending on where you look.

Were you able to find the root cause?

I'm still working on it. I don't understand why the COMMANDFAILEDERROR happens. So created this PR to get suggestions from people.

Changing this to Draft.

@joscollin joscollin marked this pull request as draft June 18, 2024 02:31
@joscollin
Copy link
Member Author

joscollin commented Jun 18, 2024 •
edited
Loading

@chrisphoffman I see similar failures in one of the squid/reef backport qa runs. I'll check that too, when I'm back on this task.

@joscollin
Copy link
Member Author

joscollin commented Jun 18, 2024

@chrisphoffman The CommandFailedError comes only when the --show-reachable=yes option is given. Otherwise, it passes the test. So I hope someone could point out why is it so.
I've been expecting a valgrind report instead of a CommandFailedError, if there's an issue with cephfs-mirror daemon. But it doesn't happen that way. Thus unsuccessful in finding the right solution.

@vshankar
Copy link
Contributor

vshankar commented Jul 1, 2024

I'm hesitant on approving this removal. What is the general stance for ceph? I see a mix of use or not depending on where you look.

It basically depends on the subsystem in question - there isn't a standardized notion in ceph for this.

@vshankar
Copy link
Contributor

vshankar commented Jul 1, 2024

@joscollin Have you run this through valgrind tests? Do you have a run to share?

@joscollin
Copy link
Member Author

joscollin commented Jul 2, 2024

@joscollin Have you run this through valgrind tests? Do you have a run to share?

@vshankar
This issue is reported/reproduced in squid branch at 4c76c50.

This is where it fails:
https://pulpito.ceph.com/jcollin-2024-07-02_02:13:12-fs:valgrind-wip-jcollin-testing-squid-distro-default-smithi/

The test passed with the fix in this PR:
https://pulpito.ceph.com/jcollin-2024-07-02_04:46:00-fs:valgrind-wip-jcollin-testing-squid-distro-default-smithi/

Both these^ tests were ran on the top of 4c76c50.

joscollin added a commit to joscollin/ceph that referenced this pull request Jul 12, 2024
@joscollin
Merge PR ceph#57987 into wip-jcollin-testing-20240712.065621-main
f7a479e 
* refs/pull/57987/head:
	qa/suites: drop --show-reachable=yes from fs:valgrind tests
joscollin added a commit to joscollin/ceph that referenced this pull request Jul 18, 2024
@joscollin
Merge PR ceph#57987 into wip-jcollin-testing-20240717.104014-main
27fbfff 
* refs/pull/57987/head:
	qa/suites: drop --show-reachable=yes from fs:valgrind tests
joscollin added a commit to joscollin/ceph that referenced this pull request Jul 23, 2024
@joscollin
Merge PR ceph#57987 into wip-jcollin-testing-20240723.094823-main
af9ab19 
* refs/pull/57987/head:
	qa/suites: drop --show-reachable=yes from fs:valgrind tests
@vshankar vshankar marked this pull request as ready for review July 24, 2024 07:41
@vshankar
Copy link
Contributor

vshankar commented Jul 30, 2024

This PR is under test in https://tracker.ceph.com/issues/67252.

vshankar added a commit to vshankar/ceph that referenced this pull request Jul 31, 2024
@vshankar
Merge PR ceph#57987 into wip-vshankar-testing-20240731.064646-debug
e89f08b 
* refs/pull/57987/head:
	qa/suites: drop --show-reachable=yes from fs:valgrind tests
vshankar added a commit to vshankar/ceph that referenced this pull request Jul 31, 2024
@vshankar
Merge PR ceph#57987 into wip-vshankar-testing-20240731.064922-debug
515e3e9 
* refs/pull/57987/head:
	qa/suites: drop --show-reachable=yes from fs:valgrind tests
vshankar
vshankar approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/projects/cephfs/wiki/Main#wip-vshankar-testing-20240731064922-debug

@vshankar vshankar merged commit f9d1924 into ceph:main Aug 7, 2024
@joscollin joscollin deleted the wip-B64752-valgrind-report-leaks branch August 7, 2024 04:20
@joscollin joscollin mentioned this pull request Aug 7, 2024
Merged
This was referenced Aug 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisphoffman chrisphoffman chrisphoffman left review comments

@vshankar vshankar vshankar approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joscollin @vshankar @chrisphoffman